TAPAAL

Merge lp:~tapaal-contributor/tapaal/slowLoad into lp:tapaal/2.1

  1. slowLoad
  2. Merge into 2.1
Proposed by Mathias Grund Sørensen
Status: Merged
Approved by: Kenneth Yrke Jørgensen
Approved revision: 704
Merged at revision: 705
Proposed branch: lp:~tapaal-contributor/tapaal/slowLoad
Merge into: lp:tapaal/2.1
Diff against target: 28 lines (+8/-3)
1 file modified
src/dk/aau/cs/gui/TemplateExplorer.java (+8/-3)
To merge this branch: bzr merge lp:~tapaal-contributor/tapaal/slowLoad
Reviewer Review Type Date Requested Status
Kenneth Yrke Jørgensen code Approve
Jiri Srba Approve
Review via email: mp+113361@code.launchpad.net

Description of the change

Redraw method for template list refactored to only draw when list is fully set up

To post a comment you must log in.
Revision history for this message
Jiri Srba (srba) wrote :

Excellent, it is way faster now.

review: Approve
Revision history for this message
Kenneth Yrke Jørgensen (yrke) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dk/aau/cs/gui/TemplateExplorer.java'
2--- src/dk/aau/cs/gui/TemplateExplorer.java 2012-07-03 15:04:02 +0000
3+++ src/dk/aau/cs/gui/TemplateExplorer.java 2012-07-04 10:25:22 +0000
4@@ -753,16 +753,21 @@
5 }
6
7 public void updateTemplateList() {
8- listModel.clear();
9+ int selectedIndex = templateList.getSelectedIndex();
10+ DefaultListModel newList = new DefaultListModel();
11+
12 if(isInAnimationMode) {
13 for (Template net : parent.activeTemplates()) {
14- listModel.addElement(net);
15+ newList.addElement(net);
16 }
17 } else {
18 for (Template net : parent.allTemplates()) {
19- listModel.addElement(net);
20+ newList.addElement(net);
21 }
22 }
23+ listModel = newList;
24+ templateList.setModel(listModel);
25+ templateList.setSelectedIndex(selectedIndex);
26 }
27
28 public void selectFirst() {

Subscribers

People subscribed via source and target branches