Merge lp:~tapaal-contributor/tapaal/set-labels-to-default-smartdraw-1841192 into lp:tapaal

Proposed by Peter Haahr Taankvist
Status: Merged
Approved by: Jiri Srba
Approved revision: 1014
Merged at revision: 1014
Proposed branch: lp:~tapaal-contributor/tapaal/set-labels-to-default-smartdraw-1841192
Merge into: lp:tapaal
Diff against target: 88 lines (+12/-38)
3 files modified
src/dk/aau/cs/gui/smartDraw/SmartDrawWorker.java (+5/-3)
src/dk/aau/cs/gui/undo/SetNameLabelPositionCommand.java (+0/-35)
src/pipe/gui/graphicElements/Arc.java (+7/-0)
To merge this branch: bzr merge lp:~tapaal-contributor/tapaal/set-labels-to-default-smartdraw-1841192
Reviewer Review Type Date Requested Status
Jiri Srba Approve
Review via email: mp+372492@code.launchpad.net

Commit message

Labels are properly set to default values when smartdrawing

To post a comment you must log in.
Revision history for this message
Jiri Srba (srba) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dk/aau/cs/gui/smartDraw/SmartDrawWorker.java'
2--- src/dk/aau/cs/gui/smartDraw/SmartDrawWorker.java 2019-08-18 08:11:04 +0000
3+++ src/dk/aau/cs/gui/smartDraw/SmartDrawWorker.java 2019-09-09 14:57:21 +0000
4@@ -9,7 +9,7 @@
5
6 import javax.swing.SwingWorker;
7
8-import dk.aau.cs.gui.undo.SetNameLabelPositionCommand;
9+import dk.aau.cs.gui.undo.UpdateNameLabelOffsetCommand;
10 import dk.aau.cs.gui.undo.Command;
11 import dk.aau.cs.gui.undo.MovePlaceTransitionObject;
12 import dk.aau.cs.util.Require;
13@@ -470,13 +470,15 @@
14 public void resetLabelsToDefault() {
15 for(PetriNetObject pNetObject : drawingSurface.getPNObjects()) {
16 if(pNetObject instanceof PlaceTransitionObject) {
17- Command cmd = new SetNameLabelPositionCommand(pNetObject, pipe.gui.Pipe.DEFAULT_OFFSET_X, pipe.gui.Pipe.DEFAULT_OFFSET_Y);
18+ Command cmd = new UpdateNameLabelOffsetCommand(pipe.gui.Pipe.DEFAULT_OFFSET_X, pipe.gui.Pipe.DEFAULT_OFFSET_Y, ((PlaceTransitionObject) pNetObject).getNameOffsetX(),
19+ ((PlaceTransitionObject) pNetObject).getNameOffsetY(), pNetObject);
20 cmd.redo();
21 undoManager.addEdit(cmd);
22
23 }
24 else if(pNetObject instanceof Arc) {
25- Command cmd = new SetNameLabelPositionCommand(pNetObject, 0, 0);
26+ Command cmd = new UpdateNameLabelOffsetCommand(0, 0, ((Arc) pNetObject).getNameOffsetX(),
27+ ((Arc) pNetObject).getNameOffsetY(), pNetObject);
28 cmd.redo();
29 undoManager.addEdit(cmd);
30 }
31
32=== removed file 'src/dk/aau/cs/gui/undo/SetNameLabelPositionCommand.java'
33--- src/dk/aau/cs/gui/undo/SetNameLabelPositionCommand.java 2019-08-18 08:11:04 +0000
34+++ src/dk/aau/cs/gui/undo/SetNameLabelPositionCommand.java 1970-01-01 00:00:00 +0000
35@@ -1,35 +0,0 @@
36-package dk.aau.cs.gui.undo;
37-
38-import pipe.gui.Grid;
39-import pipe.gui.graphicElements.PetriNetObject;
40-
41-public class SetNameLabelPositionCommand extends Command {
42- PetriNetObject object;
43- double newX;
44- double newY;
45- double oldY;
46- double oldX;
47-
48- public SetNameLabelPositionCommand(PetriNetObject object, double xOffset, double yOffset) {
49- this.object = object;
50- this.newX = xOffset;
51- this.newY = yOffset;
52- }
53-
54- @Override
55- public void undo() {
56- object.getNameLabel().setPosition(object.getX() + Grid.getModifiedX(oldX), object.getY() + Grid.getModifiedX(oldY));
57- object.updateOnMoveOrZoom();
58- }
59-
60- @Override
61- public void redo() {
62- oldY = object.getNameOffsetXObject();
63- oldX = object.getNameOffsetYObject();
64-
65- object.getNameLabel().setPosition(object.getX() + Grid.getModifiedX(newX), object.getY() + Grid.getModifiedX(newY));
66- object.updateOnMoveOrZoom();
67- }
68-}
69-
70-
71
72=== modified file 'src/pipe/gui/graphicElements/Arc.java'
73--- src/pipe/gui/graphicElements/Arc.java 2019-05-06 12:21:58 +0000
74+++ src/pipe/gui/graphicElements/Arc.java 2019-09-09 14:57:21 +0000
75@@ -116,6 +116,13 @@
76
77 abstract public void setWeight(Weight weight);
78 abstract public Weight getWeight();
79+
80+ public double getNameOffsetX() {
81+ return nameOffsetX;
82+ }
83+ public double getNameOffsetY() {
84+ return nameOffsetY;
85+ }
86
87 /**
88 * Set source

Subscribers

People subscribed via source and target branches