Merge lp:~tapaal-contributor/tapaal/fix-tikz-export-1945642 into lp:tapaal
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~tapaal-contributor/tapaal/fix-tikz-export-1945642 | ||||
Merge into: | lp:tapaal | ||||
Diff against target: |
403 lines (+224/-47) 1 file modified
src/pipe/gui/TikZExporter.java (+224/-47) |
||||
To merge this branch: | bzr merge lp:~tapaal-contributor/tapaal/fix-tikz-export-1945642 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jiri Srba | Needs Fixing | ||
Review via email: mp+410243@code.launchpad.net |
This proposal supersedes a proposal from 2021-10-14.
This proposal has been superseded by a proposal from 2021-10-17.
Commit message
Improved quality of Tikz export and various fixes
Description of the change
1. Fixed transition rotation
2. Added support for dots (replaces marking #1-5 with dots, like in the GUI)
3. Now correctly shows a place's marking (#1-2) like in the GUI
4. Improved location of place labels
5. Improved location of transition labels
6. Improved location of arc labels
7. Improved scaling so that some nets are no longer 'squished' together
8. Now currecly exports curved arcs
Other comments:
In some nets, labels for places, transitions and arcs are not positioned optimally like in the GUI. It has been difficult to find a solution to this, as some ways works for some of the nets while making other nets looks significantly worse. I'm not sure why this is. I have a suspicion it is due to the X- and Y coordinates of the labels somehow not being correct, or due to some other unintentional sideeffects. I have tried a lot of different ways to place these labels as close as possible, and have settled on the current result.
I get the following error when compiling workflow-payment example.
! Package PGF Math Error: Unknown operator `p' or `px' (in '1.33px').
See the PGF Math package documentation for explanation.
Type H <return> for immediate help.
...
l.10 ...ale=0.45, yscale=0.45, x=1.33px, y=1.33px]
?