Merge lp:~tapaal-contributor/tapaal/edit-interval-1940402 into lp:tapaal

Proposed by Lena Ernstsen
Status: Merged
Approved by: Jiri Srba
Approved revision: 1138
Merged at revision: 1141
Proposed branch: lp:~tapaal-contributor/tapaal/edit-interval-1940402
Merge into: lp:tapaal
Diff against target: 71 lines (+28/-26)
1 file modified
src/pipe/gui/widgets/GuardDialogue.java (+28/-26)
To merge this branch: bzr merge lp:~tapaal-contributor/tapaal/edit-interval-1940402
Reviewer Review Type Date Requested Status
Jiri Srba Approve
Review via email: mp+407601@code.launchpad.net

Commit message

Fixed not being able to edit right part of intervals

To post a comment you must log in.
Revision history for this message
Jiri Srba (srba) wrote :

tested and fixes the problem

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/pipe/gui/widgets/GuardDialogue.java'
2--- src/pipe/gui/widgets/GuardDialogue.java 2021-04-08 08:30:29 +0000
3+++ src/pipe/gui/widgets/GuardDialogue.java 2021-08-24 09:34:51 +0000
4@@ -561,7 +561,7 @@
5 rightDelimiter.setEnabled(true);
6 else
7 rightDelimiter.setEnabled(!inf.isSelected());
8- secondIntervalNumber.setVisible(!value);
9+ secondIntervalNumber.setVisible(!value);
10 rightConstantsComboBox.setVisible(value);
11
12 repackIfWindow();
13@@ -671,31 +671,33 @@
14 String oldRight = rightConstantsComboBox.getSelectedItem() != null ? rightConstantsComboBox
15 .getSelectedItem().toString()
16 : null;
17- rightConstantsComboBox.removeAllItems();
18- Collection<Constant> constants = CreateGui.getCurrentTab().network()
19- .constants();
20-
21- //List <Constant> constantList = new ArrayList(constants);
22- List <Constant> constantList = new ArrayList<Constant>();
23- constantList.addAll(constants);
24-
25- constantList.sort((o1, o2) -> o1.name().compareToIgnoreCase(o2.name()));
26-
27-
28- for (Constant c : constantList) {
29- if (c.value() >= value) {
30- rightConstantsComboBox.addItem(c.name());
31- }
32- }
33-
34- if(rightConstantsComboBox.getItemCount() == 0){
35- rightUseConstant.setEnabled(false);
36- } else {
37- rightUseConstant.setEnabled(true);
38- }
39-
40- if (oldRight != null)
41- rightConstantsComboBox.setSelectedItem(oldRight);
42+ rightConstantsComboBox.removeAllItems();
43+ Collection<Constant> constants = CreateGui.getCurrentTab().network()
44+ .constants();
45+
46+ //List <Constant> constantList = new ArrayList(constants);
47+ List <Constant> constantList = new ArrayList<Constant>();
48+ constantList.addAll(constants);
49+
50+ constantList.sort((o1, o2) -> o1.name().compareToIgnoreCase(o2.name()));
51+
52+
53+ for (Constant c : constantList) {
54+ if (c.value() >= value) {
55+ rightConstantsComboBox.addItem(c.name());
56+ }
57+ }
58+
59+ if(rightConstantsComboBox.getItemCount() == 0){
60+ rightUseConstant.setEnabled(false);
61+ rightUseConstant.setSelected(false);
62+ updateRightComponents();
63+ } else {
64+ rightUseConstant.setEnabled(true);
65+ }
66+
67+ if (oldRight != null)
68+ rightConstantsComboBox.setSelectedItem(oldRight);
69 }
70
71 private void firstSpinnerStateChanged(ChangeEvent evt) {

Subscribers

People subscribed via source and target branches