Merge lp:~tapaal-contributor/tapaal/Gui-freeze-1896457 into lp:tapaal
Proposed by
Peter Haahr Taankvist
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jiri Srba | ||||
Approved revision: | 1105 | ||||
Merged at revision: | 1109 | ||||
Proposed branch: | lp:~tapaal-contributor/tapaal/Gui-freeze-1896457 | ||||
Merge into: | lp:tapaal | ||||
Diff against target: |
218 lines (+53/-18) 6 files modified
src/dk/aau/cs/io/LoadedQueries.java (+18/-0) src/dk/aau/cs/io/TapnXmlLoader.java (+6/-3) src/dk/aau/cs/io/queries/QueryLoader.java (+7/-5) src/dk/aau/cs/io/queries/SUMOQueryLoader.java (+14/-3) src/dk/aau/cs/io/queries/TAPNQueryLoader.java (+5/-5) src/dk/aau/cs/io/queries/XMLQueryLoader.java (+3/-2) |
||||
To merge this branch: | bzr merge lp:~tapaal-contributor/tapaal/Gui-freeze-1896457 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jiri Srba | Approve | ||
Peter Haahr Taankvist (community) | Needs Resubmitting | ||
Kenneth Yrke Jørgensen | Needs Fixing | ||
Review via email: mp+391151@code.launchpad.net |
Commit message
I threaded the error/warning messages so that they do not halt the gui thread.
To post a comment you must log in.
Don't think we should call a gui-popup from a parser, instead use the same pattern as for the XML loader to return a list of messages/warnings.
This way the code can be reused also for other implementation not using the gui, eg. batchprocessing and commandline.