Merge lp:gearmand into lp:~1-infe-w/gearmand/gearmand

Proposed by palik
Status: Needs review
Proposed branch: lp:gearmand
Merge into: lp:~1-infe-w/gearmand/gearmand
Diff against target: 0 lines
To merge this branch: bzr merge lp:gearmand
Reviewer Review Type Date Requested Status
palik Pending
Review via email: mp+260575@code.launchpad.net

Description of the change

Bug fixing for issue
https://bugs.launchpad.net/gearmand/+bug/1417151

1. assert(unique_size) in callback_loader avoids gearmand restart if unique key doesn't exists in memcached_result_key_value

2. MEMCACHED_NOTFOUND in LibmemcachedQueue::done leads queue error:
done(QUEUE_ERROR) -> libgearman-server/plugins/queue/libmemcached/queue.cc:246
Remove from persistent queue gearman_server_run_command(QUEUE_ERROR) -> libgearman-server/server.cc:796

to reproduce:
- create X background jobs without unique keys
- stop gearmand
- start gearmad (!!!BTW only one job will be restored!!!)
- again create X background jobs without unique keys
- start worker(s)
assuming after gearmand was restarted
- one job was restored
- ten new jobs was created
- worker done all 11 job
- gearmanadmin --status shows continuously:
foo 10 0 0

To post a comment you must log in.
Revision history for this message
palik (1-infe-w) wrote :

I have to correct myself.
- gearmanadmin --status shows continuously:
foo 10 10 1

Unmerged revisions

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: