Code review comment for lp:~tamura-yoshiaki/nova/bug-764236

On Thu, Apr 21, 2011 at 3:32 AM, termie <email address hidden> wrote:
> Review: Needs Fixing
> Looks like you've got a couple pep8 errors in there still, you may want to use run_tests.sh again or grab this helper (i have a merge prop out to add it ./tools/pep8.sh): http://term.ie/data/pep8.sh
>
> Also, pep8 doesn't appear to catch the extra whitespaces on the first line of ip_dict (diff line 28), between the key and the value.
>
> Could you move the contents of the mapping dict up a line so that they begin on the same line as the mapping declaration (like ip_dict above it)?

Sorry about that termie. I checked with pep8, and also cleaned up
trailing whitespaces.
I hope everything is fine this time.

Yoshi

>
> Your test looks like it verifies your code, so works for me :)
>
>
> --
> https://code.launchpad.net/~tamura-yoshiaki/nova/bug-764236/+merge/58068
> You are the owner of lp:~tamura-yoshiaki/nova/bug-764236.
>