Code review comment for lp:~tamura-yoshiaki/nova/bug-764236

Revision history for this message
Yoshiaki Tamura (tamura-yoshiaki) wrote :

On Mon, Apr 18, 2011 at 4:24 PM, anotherjesse <email address hidden> wrote:
> A unit test would be adding a test to nova/tests/test_compute.py that resulted in network_info being set and causing exceptions to occur until your patch is applied.
>
> Sometimes errors only really manifest in deployed systems (for which we have smoketests - a series of tests that run against the API of a deployed system).
>
> How did you happen upon the bug in the first place - that might help with determining how we can add a test :)

Thanks, Jesse. I would try making a simple test case although it may
be difficult because I'm just coming across with these issues through
static review :)

Yoshi

> --
> https://code.launchpad.net/~tamura-yoshiaki/nova/bug-764236/+merge/58068
> You are the owner of lp:~tamura-yoshiaki/nova/bug-764236.
>

« Back to merge proposal