Merge lp:~tamura-yoshiaki/nova/bug-764236 into lp:~hudson-openstack/nova/trunk
Proposed by
Yoshiaki Tamura
Status: | Merged |
---|---|
Approved by: | Vish Ishaya |
Approved revision: | 996 |
Merged at revision: | 1030 |
Proposed branch: | lp:~tamura-yoshiaki/nova/bug-764236 |
Merge into: | lp:~hudson-openstack/nova/trunk |
Diff against target: |
60 lines (+38/-1) 2 files modified
nova/tests/test_virt.py (+37/-0) nova/virt/libvirt_conn.py (+1/-1) |
To merge this branch: | bzr merge lp:~tamura-yoshiaki/nova/bug-764236 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vish Ishaya (community) | Approve | ||
Devin Carlen (community) | Approve | ||
termie (community) | Approve | ||
Review via email: mp+58068@code.launchpad.net |
Commit message
Add a test checking spawn() works when network_info is set, which
currently doesn't.
The following patch would fix parameter mismatch calling _create_image() from spawn() in
libvirt_conn.py
To post a comment you must log in.
Yoshiaki - is there a way to add a smoketest or unit test that fails without your fix?