Merge lp:~talligent/charms/trusty/openbook/trunk into lp:charms/trusty/openbook
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 14 | ||||
| Proposed branch: | lp:~talligent/charms/trusty/openbook/trunk | ||||
| Merge into: | lp:charms/trusty/openbook | ||||
| Diff against target: |
242 lines (+114/-77) 2 files modified
README.md (+100/-73) metadata.yaml (+14/-4) |
||||
| To merge this branch: | bzr merge lp:~talligent/charms/trusty/openbook/trunk | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Butler (community) | Approve on 2016-01-25 | ||
| Andrew McLeod (community) | Approve on 2016-01-22 | ||
| José Antonio Rey | 2015-12-14 | Needs Fixing on 2016-01-05 | |
| Review Queue (community) | automated testing | Approve on 2015-12-18 | |
|
Review via email:
|
|||
Description of the Change
updated README and metadata with newer descriptions and tags
| Review Queue (review-queue) wrote : | # |
The results (PASS) are in and available here: http://
| José Antonio Rey (jose) wrote : | # |
Hey!
First of all, thank you for the reading improvements for the README of the OpenBook charm. I wanted to point out a couple things.
When you are using long dashes, they are not rendering correctly, meaning it can cause troubles with UTF-8 // ASCII people when reading on their browsers. I would suggest changing them for short dashes instead.
On the other hand, you are adding some tags to the metadata.yaml file. However, the only supported tags are the ones found at https:/
Apart from that, it all looks good. The README.md file does render correctly (aside from the dashes). Hope to see the next iteration of this soon!
| Andrew McLeod (admcleod) wrote : | # |
Hi Jeremy,
I've re-reviewed this - and regarding the tags - although they should also be changed to "approved" tags so we can ensure consistency in the charm store, I don't believe this should block this merge request. Similarly, with the long dashes, they should also be fixed, but this shouldn't block the merge either. If you could change this, that would be great, but regardless I am willing to give this my +1.
Andrew
| Charles Butler (lazypower) wrote : | # |
Thanks for the submission Jeremy!
I've taken Adam's feedback and taken the liberty of merging this proposal. It should be live in the charm store for consumption within the next hour.
All the best!

This item has failed automated testing! Results available here http:// juju-ci. vapour. ws:8080/ job/charm- bundle- test-lxc/ 1852/