Code review comment for lp:~taihsiangho/ubiquity/trusty-proposed

Mathieu Trudel-Lapierre (cyphermox) wrote :

I'm concerned that this is very different from the way preseeding is normally done for installations or even oem settings -- oem-config itself simply uses whatever "real" debconf keys would be used on the installed system, which means you'd absolutely have to preseed those after the initial install, rather than being able to push everything at once at install time.

In other words; I think rather than having someone touch the installed system and specify extra boot parameters, or even preseed those in a late_command (or even more complicated, boot the installer with them), we should come up with install-time preseedable keys for the questions oem-config will ask.

Simply put; I'd make a copy of timezone, keyboard, etc. under the oem-config namespace, and teach ubiquity/oem-config to read those if we're running in the oem-config case, so that only the questions that are not seeded will be asked, and you can specify all of it at the time you start the installation process. This way, you can simplify things down to a user only having to fill in their name and password.

Additionally, this depends on having a file available on the filesystem already that contains all the necessary parameters; which is unlikely. One way to handle this better would be to allow using a URL like the preseed package does, but that will need changes in ubiquity itself rather than just the upstart job.

Since this particular merge is not incorrect, please provide more information whether this has been considered, and what the exact use case is that you want to fix here.

review: Needs Information

« Back to merge proposal