Merge ~szymonpajzert/dpcs:ticket11 into dpcs:master
Proposed by
SzymonPajzert
Status: | Rejected |
---|---|
Rejected by: | Marek Bardoński |
Proposed branch: | ~szymonpajzert/dpcs:ticket11 |
Merge into: | dpcs:master |
Diff against target: |
245 lines (+198/-0) 8 files modified
server/main/__init__.py (+0/-0) server/main/api.py (+22/-0) server/main/resources/__init__.py (+1/-0) server/main/resources/crashReport.py (+59/-0) server/main/resources/crash_reports.json (+33/-0) server/main/resources/database.py (+47/-0) server/main/resources/helloWorld.py (+10/-0) server/main/resources/types.py (+26/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marek Bardoński | Pending | ||
Review via email: mp+288233@code.launchpad.net |
To post a comment you must log in.
Good job.
The server code is well designed. Flask as a easy-to-learn library is a good choice for an alpha prototype. Restful solution is the best approach to the connection between client and server in my opinion.
I think a good idea will be to create a common test folder to be used by classification and clustering algorithms.
In a few days we will try to deploy it on a server, test if everything work well in practice and the finally approve.