Code review comment for lp:~systemdisc/shutter/imgur-fix

Timothy Zorn (systemdisc) wrote :

> This worked for me!
>
> Would be great if guest uploads had a wizard to create a config file.

There's not need for guest uploads to create a config file, since the user does not need to authenticate themselves.

>
> For anyone who needs it:
>
> 1. Register here: https://api.imgur.com/oauth2/addclient (OAuth 2
> authorization without a callback URL).
> 2. Create ~/.imgur-api-config (this will be a JSON config file in your home
> dir)
> 3. Populate it with the imgur keys from step 1:
>
> {
> "client_id": "xxxxxxxxxxxxxxx",
> "client_secret": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
> }

This is incorrect. The client_id and client_secret should be set by the software, not the end user. I was letting the owner of this repository know how to get their own client_id and client_secret if they wanted it.

« Back to merge proposal