Merge lp:~synerpgy/openobject-addons/addons_61_fix into lp:openobject-addons/6.1

[YannickB (YOLO consulting)]

Hi guys,

I want to point out a rounding issue I think I have found in tax line computation. As you can see, my patch is very simple.

Here is my real case :

price unit : 102.50, quantity 2, tax 7% included

In account.invoice.line subtotal field, I find the correct value 191.59, obtains by :
round(102.50 * 2 / 1.07)

But in tax line, base field, I have the value 191.58. After some research I found the computation made :
round(round(102.50 / 1.07) * 2)
which is wrong for me.

My MP remove this useless round. Why did you made it? It's clearly a voluntary act.

I may be wrong in my computation and round(round(102.50 / 1.07) * 2) would be the correct one.
But in this case : the subtotal account.invoice.line and the base field from tax.line currently differs by their computation, we have to correct either one or the other because currently it give us different amount in the very same document.

Regards,
Yannick.

Unmerged revisions

7100. By yannick <yannick@serveur-perso> on 2012-12-11

Correct tax rounding issue

=== modified file 'account/account_invoice.py'
--- account/account_invoice.py	2012-10-05 12:58:20 +0000
+++ account/account_invoice.py	2012-12-11 16:55:27 +0000
@@ -1589,7 +1589,6 @@
 
         for line in inv.invoice_line:
             for tax in tax_obj.compute_all(cr, uid, line.invoice_line_tax_id, (line.price_unit* (1-(line.discount or 0.0)/100.0)), line.quantity, inv.address_invoice_id.id, line.product_id, inv.partner_id)['taxes']:
-                tax['price_unit'] = cur_obj.round(cr, uid, cur, tax['price_unit'])
                 val={}
                 val['invoice_id'] = inv.id
                 val['name'] = tax['name']