PlainBox (Toolkit)

Merge ~sylvain-pineau/plainbox:fix-1670344 into plainbox:master

  1. Git
  2. lp:~sylvain-pineau/plainbox
  3. fix-1670344
  4. Merge into master
Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: d7c47cd55f0fc6e67837e6ef5031467841e9afcc
Merged at revision: 17803f11d7725f89743c06b42ae1a849cfcc17bd
Proposed branch: ~sylvain-pineau/plainbox:fix-1670344
Merge into: plainbox:master
Diff against target: 18 lines (+2/-2)
1 file modified
plainbox/impl/session/state.py (+2/-2)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+319058@code.launchpad.net

Description of the change

Fixes the (pretty annoying) linked bug

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Nice and LGTM!
+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/session/state.py b/plainbox/impl/session/state.py
2index ca82553..fdcc88c 100644
3--- a/plainbox/impl/session/state.py
4+++ b/plainbox/impl/session/state.py
5@@ -583,11 +583,11 @@ class SessionDeviceContext:
6
7 def _compute_override_map(self):
8 """Compute the map of field overrides."""
9- override_map = collections.defaultdict(list)
10+ override_map = collections.OrderedDict()
11 for test_plan in self._test_plan_list:
12 support = TestPlanUnitSupport(test_plan)
13 for pattern, override_list in support.override_list:
14- override_map[pattern].extend(override_list)
15+ override_map.setdefault(pattern, []).extend(override_list)
16 return override_map
17
18 def _invalidate_override_map(self, *args, **kwargs):

Subscribers

People subscribed via source and target branches