Merge ~sylvain-pineau/plainbox-provider-resource:display-resource-wayland-support into plainbox-provider-resource:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 8901ac96bb0b52d54c9501240b07b6a95783ced9
Merged at revision: 864e57cefadbd6251b224e627483c14bd085a02f
Proposed branch: ~sylvain-pineau/plainbox-provider-resource:display-resource-wayland-support
Merge into: plainbox-provider-resource:master
Diff against target: 25 lines (+7/-2)
1 file modified
bin/display_resource.py (+7/-2)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau (community) Approve
Review via email: mp+418600@code.launchpad.net

Description of the change

This patch calls gnome-randr on wayland sessions to generate the -connected- display resources.

Note: Since a packaging meta data unit can only be declared once, it will be proposed via p-p-c

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

"10.38.105.54"
"10.38.105.108"
"10.38.105.197"
[xenial] [08:20:36] starting container
Device project added to xenial-testing
"10.38.105.54"
[xenial] [08:21:04] provisioning container
[bionic] [08:22:54] starting container
Device project added to bionic-testing
[xenial] [08:23:11] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-resource-generic
"10.38.105.156"
[bionic] [08:23:24] provisioning container
[focal] [08:23:25] starting container
[xenial] [08:23:39] container-tests-provider-resource-generic: FAIL
Device project added to focal-testing
[xenial] output: https://paste.ubuntu.com/p/BSDk8TMJNK/
[xenial] [08:23:41] Fixing file permissions in source directory
[xenial] [08:23:42] Destroying container
"10.38.105.167"
[focal] [08:23:53] provisioning container
[bionic] [08:24:53] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-resource-generic
[bionic] [08:25:22] container-tests-provider-resource-generic: FAIL
[bionic] output: https://paste.ubuntu.com/p/G8BBmgmksT/
[bionic] [08:25:24] Fixing file permissions in source directory
[bionic] [08:25:24] Destroying container
[focal] [08:26:11] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-resource-generic
[focal] [08:26:37] container-tests-provider-resource-generic: FAIL
[focal] output: https://paste.ubuntu.com/p/pPXT3gMT3p/
[focal] [08:26:39] Fixing file permissions in source directory
[focal] [08:26:39] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/display_resource.py b/bin/display_resource.py
2index 3148603..2a73373 100755
3--- a/bin/display_resource.py
4+++ b/bin/display_resource.py
5@@ -1,5 +1,6 @@
6 #!/usr/bin/env python3
7
8+import os
9 import re
10 import sys
11 import subprocess
12@@ -15,8 +16,12 @@ DP_RE = re.compile(r"dp|displayport", re.I)
13
14 def main():
15 try:
16- xrandr_output = subprocess.check_output(
17- ["xrandr", "-q", "--verbose"], universal_newlines=True)
18+ if os.getenv('XDG_SESSION_TYPE') == 'wayland':
19+ xrandr_output = subprocess.check_output(
20+ ["gnome-randr"], universal_newlines=True)
21+ else:
22+ xrandr_output = subprocess.check_output(
23+ ["xrandr", "-q", "--verbose"], universal_newlines=True)
24 except subprocess.CalledProcessError:
25 return 0
26

Subscribers

People subscribed via source and target branches