Merge ~sylvain-pineau/plainbox-provider-resource:fix-1757359 into plainbox-provider-resource:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: f7c68e6e229d9efebefc6229662b4358528d39e7
Merged at revision: ad5eec62fb1e339eef9dd28780826421cd201d69
Proposed branch: ~sylvain-pineau/plainbox-provider-resource:fix-1757359
Merge into: plainbox-provider-resource:master
Diff against target: 16 lines (+6/-0)
1 file modified
bin/display_resource (+6/-0)
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+341811@code.launchpad.net

Description of the change

Fixes linked bug

This patch reports both HDMI/DP if DP if detected in xrandr output

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

seems ok, if that's indeed what we want. No apparent downside to reporting hdmi when we only know of dp? None that I can think of, just asking for someone who might be more familiar with the tests. +1 for how it works though.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/display_resource b/bin/display_resource
2index 9ed0298..3148603 100755
3--- a/bin/display_resource
4+++ b/bin/display_resource
5@@ -82,6 +82,12 @@ def main():
6 # (for both signal format and connector type).
7 supported_connections['hdmi'] = 'supported'
8
9+ # HDMI ports are often reported as DP due to drivers/firmwares
10+ # Let's assume both are present
11+ # See https://bugs.launchpad.net/plainbox-provider-resource/+bug/1757359
12+ if supported_connections['dp'] == 'supported':
13+ supported_connections['hdmi'] = 'supported'
14+
15 for connector in supported_connections.items():
16 print("{}: {}".format(connector[0], connector[1]))
17

Subscribers

People subscribed via source and target branches