Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-1903264 into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: e33674916ef26b66f76abc368f8c14b37c807dfb
Merged at revision: bbfb992dc65a7860c6ac29ae261061b044e4715f
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-1903264
Merge into: plainbox-provider-checkbox:master
Diff against target: 9 lines (+3/-0)
1 file modified
units/serial/packaging.pxu (+3/-0)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau (community) Approve
Review via email: mp+403550@code.launchpad.net

Description of the change

Fixes linked bug (missing dep on python3-serial)

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [11:29:41] starting container
Device project added to xenial-testing
[focal] [11:29:55] starting container
[bionic] [11:29:56] starting container
Device project added to focal-testing
Device project added to bionic-testing
[xenial] [11:30:00] provisioning container
[bionic] [11:30:16] provisioning container
[focal] [11:30:16] provisioning container
[xenial] [11:30:19] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [11:30:37] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-checkbox
[focal] [11:30:56] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [11:31:58] container-tests-provider-checkbox: PASS
[xenial] [11:31:58] Fixing file permissions in source directory
[xenial] [11:31:59] Destroying container
[bionic] [11:32:35] container-tests-provider-checkbox: PASS
[bionic] [11:32:35] Fixing file permissions in source directory
[bionic] [11:32:35] Destroying container
[focal] [11:32:47] container-tests-provider-checkbox: FAIL
[focal] output: https://paste.ubuntu.com/p/TMr9Z5QFSG/
[focal] [11:32:49] Fixing file permissions in source directory
[focal] [11:32:50] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/serial/packaging.pxu b/units/serial/packaging.pxu
2new file mode 100644
3index 0000000..da25e8e
4--- /dev/null
5+++ b/units/serial/packaging.pxu
6@@ -0,0 +1,3 @@
7+unit: packaging meta-data
8+os-id: debian
9+Depends: python3-serial

Subscribers

People subscribed via source and target branches