Merge ~sylvain-pineau/plainbox-provider-checkbox:bye-package.version into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 46cb2d11c4e1bd9b541f8487c6142d80ef5be20f
Merged at revision: 4c3ca3c4713cab297107193b18a6f8fe5fe87663
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:bye-package.version
Merge into: plainbox-provider-checkbox:master
Diff against target: 22 lines (+2/-2)
1 file modified
units/bluetooth/jobs.pxu (+2/-2)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Review via email: mp+390134@code.launchpad.net

Description of the change

After the modalias removal, time to drop versions from the package resource, only used by those 2 bluez jobs.

When there's a need to constraint a job, better use in conjunction the lsb resource.

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/bluetooth/jobs.pxu b/units/bluetooth/jobs.pxu
2index 358df5e..03e1e02 100644
3--- a/units/bluetooth/jobs.pxu
4+++ b/units/bluetooth/jobs.pxu
5@@ -197,7 +197,7 @@ depends: bluetooth/detect-output
6 imports: from com.canonical.plainbox import manifest
7 requires:
8 manifest.has_bt_smart == 'True'
9- package.name == 'bluez' and package.version >= '5.37'
10+ package.name == 'bluez'
11 estimated_duration: 30.0
12 command: bt_connect.py --mouse
13 _purpose:
14@@ -216,7 +216,7 @@ depends: bluetooth/detect-output
15 imports: from com.canonical.plainbox import manifest
16 requires:
17 manifest.has_bt_smart == 'True'
18- package.name == 'bluez' and package.version >= '5.37'
19+ package.name == 'bluez'
20 estimated_duration: 30.0
21 command: bt_connect.py --keyboard
22 _purpose:

Subscribers

People subscribed via source and target branches