Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-secure_boot_mode_snappy-req into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 5299e4de64ece576c354ce22b414818b817f2baf
Merged at revision: 26be88defc7b3d92e03d429deac1e8d489ad8189
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-secure_boot_mode_snappy-req
Merge into: plainbox-provider-checkbox:master
Diff against target: 14 lines (+1/-2)
1 file modified
units/miscellanea/jobs.pxu (+1/-2)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Jonathan Cave (community) Approve
Review via email: mp+376992@code.launchpad.net

Description of the change

Fix the secure boot test req

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks, makes sense

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [09:11:41] starting container
Device project added to xenial-testing
[bionic] [09:11:48] starting container
Device project added to bionic-testing
[xenial] [09:11:51] provisioning container
[bionic] [09:12:00] provisioning container
[bionic] [09:12:12] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/FSZkBgGZw2/
[bionic] [09:12:14] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [09:55:55] Unable to provision requirements in container!
[xenial] output: https://paste.ubuntu.com/p/xKsr6s2Vbb/
[xenial] [09:55:58] Fixing file permissions in source directory
[xenial] Destroying failed container to reclaim resources

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/miscellanea/jobs.pxu b/units/miscellanea/jobs.pxu
2index bbb28bf..1f008cb 100644
3--- a/units/miscellanea/jobs.pxu
4+++ b/units/miscellanea/jobs.pxu
5@@ -154,8 +154,7 @@ unit: template
6 template-resource: model_assertion
7 template-unit: job
8 requires:
9- executable.name == 'dumpimage'
10- executable.name == 'mokutil'
11+ executable.name == 'dumpimage' or executable.name == 'mokutil'
12 id: miscellanea/secure_boot_mode_{gadget}
13 _summary: Test that {gadget} Ubuntu Core system booted with Secure Boot active
14 _description:

Subscribers

People subscribed via source and target branches