Merge ~sylvain-pineau/plainbox-provider-checkbox:disk_read_performance_test_nvme_200 into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: bddeed5212e1927814e375debc26a8b01589f13c
Merged at revision: 7a09a7291cd00f54e9a183ab681c885fe17e066a
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:disk_read_performance_test_nvme_200
Merge into: plainbox-provider-checkbox:master
Diff against target: 13 lines (+1/-1)
1 file modified
bin/disk_read_performance_test (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+375882@code.launchpad.net

Description of the change

<3 tampere

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Beginning /tmp/nest-otdhir1f.a3fe81c5d3a15f869860bcadc011746d0dce67ec76c445fe29c1b2d01276ecbc/disk_read_performance_test test for nvme0n1
---------------------------------------------------
INFO: nvme0n1 type is nvme
INFO: nvme: Using 400 MB/sec as the minimum throughput speed

Beginning hdparm timing runs
---------------------------------------------------
INFO: Iteration 1: Detected speed is 271.08 MB/sec
INFO: Iteration 2: Detected speed is 275.82 MB/sec
INFO: Iteration 3: Detected speed is 261.59 MB/sec
INFO: Iteration 4: Detected speed is 276.06 MB/sec
INFO: Iteration 5: Detected speed is 270.49 MB/sec
INFO: Iteration 6: Detected speed is 277.89 MB/sec
INFO: Iteration 7: Detected speed is 275.02 MB/sec
INFO: Iteration 8: Detected speed is 271.09 MB/sec
INFO: Iteration 9: Detected speed is 271.53 MB/sec
INFO: Iteration 10: Detected speed is 272.57 MB/sec
INFO: Maximum detected speed is 277 MB/sec
---------------------------------------------------

FAIL: nvme0n1 Max Speed of 277 MB/sec is slower than Minimum Buffer Read Speed of 400 MB/sec
WARNING: One or more disks failed testing!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/disk_read_performance_test b/bin/disk_read_performance_test
2index 972c5b6..1310621 100755
3--- a/bin/disk_read_performance_test
4+++ b/bin/disk_read_performance_test
5@@ -45,7 +45,7 @@ for disk in $@; do
6 "devmapper" ) MIN_BUF_READ=$DEFAULT_BUF_READ;;
7 "ide" ) MIN_BUF_READ=40;;
8 "mmc" ) MIN_BUF_READ=$DEFAULT_BUF_READ;;
9- "nvme" ) MIN_BUF_READ=400;;
10+ "nvme" ) MIN_BUF_READ=200;;
11 * ) MIN_BUF_READ=$DEFAULT_BUF_READ;;
12 esac
13 echo "INFO: $disk_type: Using $MIN_BUF_READ MB/sec as the minimum throughput speed"

Subscribers

People subscribed via source and target branches