Checkbox Provider - Base

Merge ~sylvain-pineau/plainbox-provider-checkbox:collect-manifest-non-mandatory into plainbox-provider-checkbox:master

  1. Git
  2. lp:~sylvain-pineau/plainbox-provider-checkbox
  3. collect-manifest-non-mandatory
  4. Merge into master
Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: e02e789ed24dde13d91a859dd96f346d21d552e0
Merged at revision: b3f1eb36ed6d9a855cbeede4e8e75fd8ecea5768
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:collect-manifest-non-mandatory
Merge into: plainbox-provider-checkbox:master
Diff against target: 12 lines (+0/-1)
1 file modified
units/submission/test-plan.pxu (+0/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Needs Resubmitting
Jonathan Cave (community) Approve
Review via email: mp+375847@code.launchpad.net

Description of the change

Move collect-manifest to standard include otherwise session assistant can't exclude it.
To comply with manifest V2 where manifest questions are handled via a new urwid screen.

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Do we need to make sure this is done everywhere collect-manifest is used?

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Actually let's remove it since sa will exclude it

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/submission/test-plan.pxu b/units/submission/test-plan.pxu
2index 3bb4cd3..5ae692f 100644
3--- a/units/submission/test-plan.pxu
4+++ b/units/submission/test-plan.pxu
5@@ -4,7 +4,6 @@ _name: Submission resources
6 _description: Submission resources
7 include:
8 mandatory_include:
9- com.canonical.plainbox::collect-manifest
10 miscellanea/device_check
11 # Meta-job to include required resources, don't remove.
12 miscellanea/submission-resources

Subscribers

People subscribed via source and target branches