Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-disk-read-perf-test-nvme into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: d62a476e5b4e6b94ba247e8fb8f4fea22dabf82b
Merged at revision: 26cc8a96b718ffde13d57965279f6869a3adf710
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-disk-read-perf-test-nvme
Merge into: plainbox-provider-checkbox:master
Diff against target: 34 lines (+8/-1)
1 file modified
bin/disk_read_performance_test (+8/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+373797@code.launchpad.net

Description of the change

Spotted while working on https://bugs.launchpad.net/plainbox-provider-checkbox/+bug/1819436, the disk_read_performance_test was not supporting nvme drives.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/disk_read_performance_test b/bin/disk_read_performance_test
2index 00810a5..1cdea0d 100755
3--- a/bin/disk_read_performance_test
4+++ b/bin/disk_read_performance_test
5@@ -13,6 +13,12 @@ for disk in $@; do
6
7 disk_type=`udevadm info --name /dev/$disk --query property | grep "ID_BUS" | awk '{gsub(/ID_BUS=/," ")}{printf $1}'`
8 dev_path=`udevadm info --name /dev/$disk --query property | grep "DEVPATH" | awk '{gsub(/DEVPATH=/," ")}{printf $1}'`
9+ if [[ $dev_path =~ nvme ]]; then
10+ disk_type="nvme"
11+ fi
12+ if [ -z "$disk_type" ]; then
13+ exit 1
14+ fi
15 echo "INFO: $disk type is $disk_type"
16
17 case $disk_type in
18@@ -30,6 +36,7 @@ for disk in $@; do
19 fi
20 ;;
21 "ide" ) MIN_BUF_READ=40;;
22+ "nvme" ) MIN_BUF_READ=1000;;
23 * ) MIN_BUF_READ=$DEFAULT_BUF_READ;;
24 esac
25 echo "INFO: $disk_type: Using $MIN_BUF_READ MB/sec as the minimum throughput speed"
26@@ -45,7 +52,7 @@ for disk in $@; do
27
28 if [ -z "$speed" ]; then
29 echo "WARNING: Device $disk is too small! Aborting test."
30- exit 0
31+ exit 1
32 fi
33
34 speed=${speed/.*}

Subscribers

People subscribed via source and target branches