Checkbox Provider - Base

Merge ~sylvain-pineau/plainbox-provider-checkbox:remove-no_ACPI_REV_interface into plainbox-provider-checkbox:master

  1. Git
  2. lp:~sylvain-pineau/plainbox-provider-checkbox
  3. remove-no_ACPI_REV_interface
  4. Merge into master
Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 183766f0c778b17ee67dd26a2755eccc25aba233
Merged at revision: 3b1bf8cf5b3ebcdc93ef79b7bb11c5792de4c8f8
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:remove-no_ACPI_REV_interface
Merge into: plainbox-provider-checkbox:master
Diff against target: 40 lines (+0/-11)
2 files modified
units/firmware/jobs.pxu (+0/-9)
units/miscellanea/test-plan.pxu (+0/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+373496@code.launchpad.net

Description of the change

Removal of deprecated test: no_ACPI_REV_interface

Context: _REV=5 stops working for a few years and we should expect _REV=2 always and no new systems should use them anymore.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/firmware/jobs.pxu b/units/firmware/jobs.pxu
2index 4dae484..9ebc734 100644
3--- a/units/firmware/jobs.pxu
4+++ b/units/firmware/jobs.pxu
5@@ -66,15 +66,6 @@ command:
6 _description: Attaches the FWTS desktop diagnosis results log to the submission (to HWE)
7 _summary: Attach FWTS desktop diagnosis log to submission (to HWE)
8
9-plugin: shell
10-category_id: com.canonical.plainbox::firmware
11-id: firmware/no_ACPI_REV_interface
12-_summary: No _REV interface in ACPI [DS]SDT tables
13-user: root
14-estimated_duration: 0.5
15-command: ! sudo grep -r "_REV" /sys/firmware/acpi/tables/* | grep [DS]SDT
16-_description: This Automated test checks misuse of the _REV interface in ACPI DSDT and SSDT tables
17-
18 plugin:shell
19 category_id: com.canonical.plainbox::firmware
20 id: firmware/fwts_server
21diff --git a/units/miscellanea/test-plan.pxu b/units/miscellanea/test-plan.pxu
22index b63d34f..1b119f1 100644
23--- a/units/miscellanea/test-plan.pxu
24+++ b/units/miscellanea/test-plan.pxu
25@@ -30,7 +30,6 @@ include:
26 firmware/fwts_desktop_diagnosis_results.log.gz
27 firmware/fwts_wakealarm.* certification-status=blocker
28 firmware/fwts_uefirtvariable.* certification-status=blocker
29- firmware/no_ACPI_REV_interface certification-status=blocker
30 miscellanea/oops certification-status=blocker
31 miscellanea/oops_results.log
32 miscellanea/dmitest_client
33@@ -49,7 +48,6 @@ include:
34 firmware/fwts_desktop_diagnosis_results.log.gz
35 firmware/fwts_wakealarm.* certification-status=blocker
36 firmware/fwts_uefirtvariable.* certification-status=blocker
37- firmware/no_ACPI_REV_interface certification-status=blocker
38 miscellanea/oops certification-status=blocker
39 miscellanea/oops_results.log
40 bootstrap_include:

Subscribers

People subscribed via source and target branches