Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-1839667 into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: b187caa7e59999e9f949ecb2f0312939e8094d26
Merged at revision: 974145babe60757bc40e96cd4d1912c1cb163ca5
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-1839667
Merge into: plainbox-provider-checkbox:master
Diff against target: 17 lines (+2/-4)
1 file modified
units/submission/jobs.pxu (+2/-4)
Reviewer Review Type Date Requested Status
Sheila Miguez (community) Approve
Checkbox Developers Pending
Review via email: mp+373279@code.launchpad.net

Description of the change

Not really a fix, but a method to see it fixed on C3 side.

This patch exposes all DMI data into the raw-devices-dmi attachment, not just bios and system.
It adds the missing information about the processor (serial, vendor, version, ...)

tested by just running the following command on my system:

$ checkbox-cli run .*raw_devices_dmi_json -f json

PROCESSOR category is part of the raw-devices-dmi: https://pastebin.canonical.com/p/t6yFRx6CbK/

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

woot

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/submission/jobs.pxu b/units/submission/jobs.pxu
2index a2f5382..b433fd3 100644
3--- a/units/submission/jobs.pxu
4+++ b/units/submission/jobs.pxu
5@@ -22,10 +22,8 @@ requires:
6 dmi_present.state == 'supported'
7 user: root
8 command:
9- dmidecode -t bios -t system | python3 -m plainbox dev parse dmidecode | \
10- jq '[.[0]._attributes +
11- {"category": .[0].category}, .[1]._attributes +
12- {"category": .[1].category}]'
13+ dmidecode | python3 -m plainbox dev parse dmidecode | \
14+ jq '[.[] | ._attributes + {"category": .category}]'
15 estimated_duration: 1
16 _description: Attaches dmidecode output
17 _summary: Attaches json dumps of udev_resource raw dmi devices

Subscribers

People subscribed via source and target branches