Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-oob-inline-comments into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3b2c700d8010ec5aa560649d35bd31cd831ecebc
Merged at revision: 36f0620a97cc56a069fb2773bd559f5ce990981c
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-oob-inline-comments
Merge into: plainbox-provider-checkbox:master
Diff against target: 21 lines (+2/-2)
1 file modified
units/oob-management/jobs.pxu (+2/-2)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Review via email: mp+363364@code.launchpad.net

Description of the change

Found while running the prototype of the snapped provider validation tool.

If a requires job field is made of just a comment, validation fails:

e.g:

requires:
  # a comment

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Looks good to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/oob-management/jobs.pxu b/units/oob-management/jobs.pxu
2index 5615a65..cf3ebd1 100644
3--- a/units/oob-management/jobs.pxu
4+++ b/units/oob-management/jobs.pxu
5@@ -113,14 +113,14 @@ plugin: shell
6 template-engine: jinja2
7 requires:
8 {%- if __on_ubuntucore__ %}
9- # TODO: name is a guess until snap provided
10+ {# TODO: name is a guess until snap provided #}
11 snap.name == 'lms'
12 {%- else %}
13 package.name == 'lms'
14 {% endif -%}
15 command:
16 {%- if __on_ubuntucore__ %}
17- # TODO: name is a guess until snap provided
18+ {# TODO: name is a guess until snap provided #}
19 SERVICE_NAME="snap.lms.lms.service"
20 {%- else %}
21 SERVICE_NAME="lms.service"

Subscribers

People subscribed via source and target branches