Merge ~sylvain-pineau/plainbox-provider-checkbox:system_more_dbg_ouput into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 75ec7ea93ecd6e061d85b0303f60cf43f82aaaf2
Merged at revision: 75ec7ea93ecd6e061d85b0303f60cf43f82aaaf2
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:system_more_dbg_ouput
Merge into: plainbox-provider-checkbox:master
Diff against target: 19 lines (+3/-1)
1 file modified
bin/system_info.py (+3/-1)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau (community) Approve
Review via email: mp+359989@code.launchpad.net

Description of the change

More info when this job fails to run inxi/udev_resource.

It runs well with local invocations but not remote, this commit will help to understand why in the future.

Tested locally with a broken inxi, the tarball can still be generated.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self.aprroved

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [10:51:35] starting container
[xenial] [10:51:37] Unable to start ephemeral container!
[xenial] output: https://paste.ubuntu.com/p/PwbXzrzbyf/
[xenial] NOTE: unable to execute tests, marked as failed
[xenial] Destroying failed container to reclaim resources
[bionic] [10:51:43] starting container
[trusty] [10:51:44] starting container
[bionic] [10:51:45] Unable to start ephemeral container!
Device project added to trusty-testing
[bionic] output: https://paste.ubuntu.com/p/zYvVkQq95M/
[bionic] NOTE: unable to execute tests, marked as failed
[bionic] Destroying failed container to reclaim resources
[trusty] [10:52:02] provisioning container
[trusty] [10:52:52] Starting tests...
[trusty] Found a test script: ./requirements/container-tests-provider-checkbox
[trusty] [10:53:46] container-tests-provider-checkbox: PASS
[trusty] [10:53:46] Fixing file permissions in source directory
[trusty] [10:53:47] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/system_info.py b/bin/system_info.py
2index 47e054e..d03ae4a 100755
3--- a/bin/system_info.py
4+++ b/bin/system_info.py
5@@ -22,13 +22,15 @@ from collections import OrderedDict
6 import json
7 import re
8 import subprocess
9+import sys
10
11
12 def _run_cmd(cmd):
13 try:
14 return subprocess.check_output(
15 cmd, shell=True, universal_newlines=True)
16- except subprocess.CalledProcessError:
17+ except subprocess.CalledProcessError as e:
18+ print(e.output, file=sys.stderr)
19 return None
20
21

Subscribers

People subscribed via source and target branches