Merge ~sylvain-pineau/plainbox-provider-checkbox:system_info_environ into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 564ce9283220a8b1590414a41b5d507cc4f68606
Merged at revision: 1882bffbe5b56043212805d6d07c4cb0fa937f04
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:system_info_environ
Merge into: plainbox-provider-checkbox:master
Diff against target: 16 lines (+5/-1)
1 file modified
units/submission/jobs.pxu (+5/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+359762@code.launchpad.net

Description of the change

Still run system_info as root, but add PERL5LIB to environ. it helps gathering more devices (e.g usb modems)

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/submission/jobs.pxu b/units/submission/jobs.pxu
2index 7d20950..faa0647 100644
3--- a/units/submission/jobs.pxu
4+++ b/units/submission/jobs.pxu
5@@ -86,6 +86,10 @@ command: recovery_info version | python3 -m plainbox dev parse recovery-info
6 id: system_info_json
7 plugin: attachment
8 category_id: com.canonical.plainbox::info
9-command: system_info.py
10+command:
11+ export LC_ALL=C.UTF-8
12+ system_info.py
13+user: root
14+environ: PERL5LIB
15 _description: Attaches json dumps of system info tools (inxi + udev)
16 _summary: Attaches json dumps of system info tools

Subscribers

People subscribed via source and target branches