Merge ~sylvain-pineau/plainbox-provider-checkbox:configurable_disk_read_perf into plainbox-provider-checkbox:master

[Sylvain Pineau]

configurable read speed threshold (mainly to set a lower value on slow IOT systems)

Tested with a threshold of 10000:

$ export DISK_READ_PERF=10000

[...]

-------------[ Running job 28 / 28. Estimated time left: unknown ]--------------
---------------------[ Disk performance test for nvme0n1 ]----------------------
ID: com.canonical.certification::disk/read_performance_nvme0n1
Category: com.canonical.plainbox::disk
... 8< -------------------------------------------------------------------------
Beginning /tmp/nest-a77r2h0v.a3fe81c5d3a15f869860bcadc011746d0dce67ec76c445fe29c1b2d01276ecbc/disk_read_performance_test test for nvme0n1
---------------------------------------------------
INFO: nvme0n1 type is
INFO: : Using 10000 MB/sec as the minimum throughput speed

Beginning hdparm timing runs
---------------------------------------------------
INFO: Iteration 1: Detected speed is 1950.90 MB/sec
INFO: Iteration 2: Detected speed is 1922.77 MB/sec
INFO: Iteration 3: Detected speed is 1971.30 MB/sec
INFO: Iteration 4: Detected speed is 2004.74 MB/sec
INFO: Iteration 5: Detected speed is 1921.95 MB/sec
INFO: Iteration 6: Detected speed is 1982.64 MB/sec
INFO: Iteration 7: Detected speed is 1934.61 MB/sec
INFO: Iteration 8: Detected speed is 1903.95 MB/sec
INFO: Iteration 9: Detected speed is 1945.92 MB/sec
INFO: Iteration 10: Detected speed is 1874.91 MB/sec
INFO: Maximum detected speed is 2004 MB/sec
---------------------------------------------------

FAIL: nvme0n1 Max Speed of 2004 MB/sec is slower than Minimum Buffer Read Speed of 10000 MB/sec
WARNING: One or more disks failed testing!
------------------------------------------------------------------------- >8 ---
Outcome: job failed

[Maciej Kisielewski (kissiel)]

Looks good! +1

review: Approve

[Jonathan Cave (jocave)]

So is 15 MB/sec the exception or the reasonable default performance? If it's the exception should a faster read be used as the default?

review: Needs Information

diff --git a/bin/disk_read_performance_test b/bin/disk_read_performance_test
index e2a219d..00810a5 100755
--- a/bin/disk_read_performance_test
+++ b/bin/disk_read_performance_test
@@ -4,7 +4,7 @@
 #
 
 #Default to a lower bound of 15 MB/s
-DEFAULT_BUF_READ=15
+DEFAULT_BUF_READ=${DISK_READ_PERF:-15}
 
 for disk in $@; do
 
diff --git a/units/disk/jobs.pxu b/units/disk/jobs.pxu
index 2ee08d7..3de5532 100644
--- a/units/disk/jobs.pxu
+++ b/units/disk/jobs.pxu
@@ -61,6 +61,7 @@ requires:
 _summary: Disk performance test for {product_slug}
 _description: Verify that disk storage performs at or above baseline performance
 user: root
+environ: DISK_READ_PERF
 command: disk_read_performance_test {name}
 
 unit: template