Checkbox Provider - Base

Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-1768443 into plainbox-provider-checkbox:master

  1. Git
  2. lp:~sylvain-pineau/plainbox-provider-checkbox
  3. fix-1768443
  4. Merge into master
Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 91e32f73db31101131c2ef8d1bf80701a01fbb8b
Merged at revision: 576645a9664aec867f15efbecd878f7475276faf
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-1768443
Merge into: plainbox-provider-checkbox:master
Diff against target: 15 lines (+2/-2)
1 file modified
bin/pm_test (+2/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+344936@code.launchpad.net

Description of the change

Fix linked bug

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

tested on both 16.04/18.04. The terminal correctly handles the respawn command.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/pm_test b/bin/pm_test
2index c555ab5..d1bd3b1 100755
3--- a/bin/pm_test
4+++ b/bin/pm_test
5@@ -206,8 +206,8 @@ class PowerManagementOperation():
6 MessageDialog(title, message).run()
7 if self.args.checkbox_respawn_cmd:
8 subprocess.run(
9- 'DISPLAY=:0 x-terminal-emulator -e "sudo -u '
10- '{} bash -c \"source {}; exec bash\""'.format(
11+ r'DISPLAY=:0 x-terminal-emulator -e "sudo -u '
12+ r'{} bash -c \"source {}; exec bash\""'.format(
13 self.user, self.args.checkbox_respawn_cmd), shell=True)
14
15 def teardown(self):

Subscribers

People subscribed via source and target branches