Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-1701226 into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: a70c97fd5bf7cab7826253c15f4d5b4f1f88e079
Merged at revision: b815c58410017a57c0fee9d6f8102b1a444393d7
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-1701226
Merge into: plainbox-provider-checkbox:master
Diff against target: 43 lines (+2/-14)
2 files modified
jobs/input.txt.in (+1/-13)
jobs/miscellanea.txt.in (+1/-1)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+326991@code.launchpad.net

Description of the change

Automation of the accelerometer detection

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

LGTM! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/input.txt.in b/jobs/input.txt.in
2index b1cbe61..0bf880d 100644
3--- a/jobs/input.txt.in
4+++ b/jobs/input.txt.in
5@@ -41,24 +41,12 @@ _description:
6 VERIFICATION:
7 Is your keyboard working properly?
8
9-plugin: manual
10-category_id: com.canonical.plainbox::input
11-id: input/accelerometer_verify
12-estimated_duration: 30.0
13-_description:
14- PURPOSE:
15- Manual detection of accelerometer.
16- STEPS:
17- 1. Look at the specifications for your system.
18- VERIFICATION:
19- Is this system supposed to have an accelerometer?
20-
21 plugin: user-interact
22 category_id: com.canonical.plainbox::input
23 id: input/accelerometer
24 estimated_duration: 60.0
25 user: root
26-depends: input/accelerometer_verify
27+requires: device.category == 'ACCELEROMETER'
28 command: accelerometer_test -m
29 _description:
30 PURPOSE:
31diff --git a/jobs/miscellanea.txt.in b/jobs/miscellanea.txt.in
32index fe26ae1..dc79a32 100644
33--- a/jobs/miscellanea.txt.in
34+++ b/jobs/miscellanea.txt.in
35@@ -325,7 +325,7 @@ plugin: user-interact-verify
36 category_id: com.canonical.plainbox::miscellanea
37 estimated_duration: 5.0
38 id: miscellanea/device_check
39-command: udev_resource -l VIDEO NETWORK WIRELESS DISK | tee >([[ $DISPLAY ]] && zenity --text-info --title="Device report")
40+command: udev_resource -l VIDEO NETWORK WIRELESS DISK ACCELEROMETER | tee >([[ $DISPLAY ]] && zenity --text-info --title="Device report")
41 _summary: Device Check
42 _purpose:
43 Device check

Subscribers

People subscribed via source and target branches