Merge ~sylvain-pineau/plainbox-provider-checkbox:fix-1692764 into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: e70acdc8e7259db57f31c017d7525984ca2d489f
Merged at revision: c6b63c5321c0b4652d0add678b9a0faf512855cb
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:fix-1692764
Merge into: plainbox-provider-checkbox:master
Diff against target: 14 lines (+2/-1)
1 file modified
bin/dmitest (+2/-1)
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+325820@code.launchpad.net

Description of the change

Fixes the linked bug

Tested ok with the logs attached by Gabriel using sudo ./dmitest --test_versions --test_serials desktop --dmifile ~/Desktop/Newton2-4-dmidecord.log

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

+1, nice to have logs to test with! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/dmitest b/bin/dmitest
2index d75aa37..ef416ca 100755
3--- a/bin/dmitest
4+++ b/bin/dmitest
5@@ -132,7 +132,8 @@ def standard_tests(args, stream, dmi_data):
6 'Type:',
7 ['notebook', 'portable', 'laptop', 'desktop',
8 'lunch box', 'space-saving', 'tower',
9- 'all in one', 'hand held'], False):
10+ 'all in one', 'hand held',
11+ 'convertible'], False):
12 dmi_data['Chassis Information']['Type'] += \
13 " *** Incorrect or unknown desktop chassis type!"
14 retval += 1

Subscribers

People subscribed via source and target branches