Merge ~sylvain-pineau/plainbox-provider-checkbox:no_prefix_block_resource into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 8a751bc7f6a25f1031c6dff2e2e440b3bfad9c8e
Merged at revision: af7c972ea51e8ddcfbd800b5e1d640d809c697e8
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:no_prefix_block_resource
Merge into: plainbox-provider-checkbox:master
Diff against target: 71 lines (+7/-7)
2 files modified
jobs/disk.txt.in (+6/-6)
jobs/info.txt.in (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Review via email: mp+321819@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/disk.txt.in b/jobs/disk.txt.in
2index e7d8eaf..8d22fb3 100644
3--- a/jobs/disk.txt.in
4+++ b/jobs/disk.txt.in
5@@ -17,7 +17,7 @@ category_id: 2013.com.canonical.plainbox::disk
6 id: disk/stats_{name}
7 flags: deprecated
8 requires:
9- block_device.{name}_state != 'removable'
10+ block_device.state != 'removable' and block_device.name == '{name}'
11 user: root
12 command: disk_stats_test {name}
13 _description: This test checks {name} disk stats, generates some activity and rechecks stats to verify they've changed. It also verifies that disks appear in the various files they're supposed to.
14@@ -31,7 +31,7 @@ id: disk/smart_{name}
15 estimated_duration: 180.0
16 requires:
17 package.name == 'smartmontools'
18- block_device.{name}_smart == 'True'
19+ block_device.smart == 'True' and block_device.name == '{name}'
20 _summary:
21 Test SMART capabilities for {product}
22 _description:
23@@ -47,7 +47,7 @@ category_id: 2013.com.canonical.plainbox::disk
24 id: disk/read_performance_{name}
25 estimated_duration: 65.0
26 requires:
27- block_device.{name}_state != 'removable'
28+ block_device.state != 'removable' and block_device.name == '{name}'
29 _summary: Disk performance test for {product}
30 _description: Disk performance test for {product}
31 user: root
32@@ -62,7 +62,7 @@ id: disk/storage_device_{name}
33 estimated_duration: 375.0
34 user: root
35 requires:
36- block_device.{name}_state != 'removable'
37+ block_device.state != 'removable' and block_device.name == '{name}'
38 _summary: Disk I/O stress test for {product}
39 _description: Disk I/O stress test for {product}
40 command: storage_test {name}
41@@ -77,7 +77,7 @@ estimated_duration: 4560.0
42 user: root
43 requires:
44 package.name == 'stress-ng'
45- block_device.{name}_state != 'removable'
46+ block_device.state != 'removable' and block_device.name == '{name}'
47 _summary: Disk stress_ng test for {product}
48 _description: Disk stress_ng test for {product}
49 command: disk_stress_ng {name} --base-time 240 --really-run
50@@ -91,7 +91,7 @@ id: disk/disk_cpu_load_{name}
51 estimated_duration: 15
52 user: root
53 requires:
54- block_device.{name}_state != 'removable'
55+ block_device.state != 'removable' and block_device.name == '{name}'
56 _summary: Check of CPU load imposed by {product}
57 _description: Check to ensure CPU load of {product} is not too high
58 command: disk_cpu_load {name}
59diff --git a/jobs/info.txt.in b/jobs/info.txt.in
60index f8f632f..05b6f93 100644
61--- a/jobs/info.txt.in
62+++ b/jobs/info.txt.in
63@@ -239,7 +239,7 @@ id: info/hdparm_{name}.txt
64 estimated_duration: 1.0
65 requires:
66 package.name == 'hdparm'
67- block_device.{name}_state != 'removable'
68+ block_device.state != 'removable' and block_device.name == '{name}'
69 user: root
70 command: hdparm -I /dev/{name}
71 _summary: Attaches info from hdparm about {name}

Subscribers

People subscribed via source and target branches