Merge ~sylvain-pineau/plainbox-provider-certification-server:pmr_hook into plainbox-provider-certification-server:master

[Sylvain Pineau]

New pmr hook to run the provider validation before merging new code

[Paul Larson (pwlars)]

Neat! Is there a good way to test this without actually merging it?

[Jeff Lane  (bladernr)]

Since I'm new to this, what to the files in /requirements actually to?

For example, why does repo-core.txt specify the dev ppa?

[Sylvain Pineau (sylvain-pineau)]

@Paul, I can patch my pmr instance to do a dry run and paste the logs here for reference.

@Jeff, to validate the server provider we need to have the checkbox one as all job ids in your test plans are referencing jobs from this base provider. Pulling from checkbox trunk might sound like a good idea but bzr trunk will soon move to individual git repos. So that's not an option. Ideally I should develop the checkbox provider from its got repo (but we don't have it yet). So a workaround is to pull it from the daily builds.

that way we can validate the provider.

Note that we need both the checkbox provider and plainbox, the first the the above reason the second as it implements the modules imported by manage.py.

[Sylvain Pineau (sylvain-pineau)]

Set to approved just for the dry run

review: Approve

[Sylvain Pineau (sylvain-pineau)]

I tried to merge it but there are some problems. Typically you want to merge or rebase and try again.

review: Needs Fixing

[Paul Larson (pwlars)]

Yeah, I think that highlights something that we (or someone) needs to fix with PMR too. I find it quite annoying that it sends a separate email saying "there were problems" leaving you to figure it out. Tarmac handles that a lot better I think.

[Sylvain Pineau (sylvain-pineau)]

the log from the dry run: http://pastebin.ubuntu.com/23174060/

It took a while as in the meantime I apply the patch that Colin wrote to reword the commit msg. And it failed because I didn't set a git user nor email for pmr.

I'll update my charm to have that set up automatically

[Sylvain Pineau (sylvain-pineau)]

Colin's patch: https://code.launchpad.net/~cjwatson/pmr/+git/pmr/+merge/305538

[Paul Larson (pwlars)]

nice, looks like it's working well now. +1

review: Approve

diff --git a/.pmr-merge-hook b/.pmr-merge-hook
new file mode 100755
index 0000000..9c894b0
--- /dev/null
+++ b/.pmr-merge-hook
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+set -e
+
+git clone https://git.launchpad.net/~checkbox-dev/checkbox/+git/support
+time -o timing.dat ./support/test-in-lxc.sh
+echo "Complete test time:"
+cat timing.dat
diff --git a/requirements/deb-core.txt b/requirements/deb-core.txt
new file mode 100644
index 0000000..e26bc74
--- /dev/null
+++ b/requirements/deb-core.txt
@@ -0,0 +1,2 @@
+plainbox
+plainbox-provider-checkbox
diff --git a/requirements/repo-core.txt b/requirements/repo-core.txt
new file mode 100644
index 0000000..9865f44
--- /dev/null
+++ b/requirements/repo-core.txt
@@ -0,0 +1 @@
+checkbox-dev/ppa