Merge ~sylvain-pineau/plainbox-provider-canonical-certification:converged_launchers into plainbox-provider-canonical-certification:master-client

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 22e274bed340a2f8aab87356655ac3cb5881f17a
Merged at revision: 22e274bed340a2f8aab87356655ac3cb5881f17a
Proposed branch: ~sylvain-pineau/plainbox-provider-canonical-certification:converged_launchers
Merge into: plainbox-provider-canonical-certification:master-client
Diff against target: 170 lines (+14/-49)
3 files modified
dev/null (+0/-22)
launcher/canonical-certification-cli (+2/-2)
launcher/canonical-certification-client (+12/-25)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+296098@code.launchpad.net

Description of the change

Launchers update to use the new ui type "converged" and finally replace checkbox-gui shebang.
The default testplan is now 16.04 and the testplan filters only selects certification test plans.
This MR also removes obsolete launchers (-gui and canonical-hw-collection)

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launcher/canonical-certification-cli b/launcher/canonical-certification-cli
2index e653c48..9d6ccb8 100755
3--- a/launcher/canonical-certification-cli
4+++ b/launcher/canonical-certification-cli
5@@ -5,5 +5,5 @@ launcher_version = 1
6 stock_reports = text, submission_files, certification
7
8 [test plan]
9-unit = 2013.com.canonical.certification::client-cert-14-04
10-filter = *
11+unit = 2013.com.canonical.certification::client-cert-16-04
12+filter = *client-cert*, *client-selftest*, *client-hwe*
13diff --git a/launcher/canonical-certification-client b/launcher/canonical-certification-client
14index a0b4d96..181d5d7 100755
15--- a/launcher/canonical-certification-client
16+++ b/launcher/canonical-certification-client
17@@ -1,25 +1,12 @@
18-#!/usr/bin/checkbox-gui
19-
20-[welcome]
21-title = "System Certification"
22-text = "<p>Welcome to System Certification!</p><p></p><p>This application will
23- gather information from your system. Then you will be asked manual tests to
24- confirm that the system is working properly. Finally, you will be asked for
25- the Secure ID of the computer to submit the information to the certification
26- database.</p><p></p><p> To learn how to create or locate the Secure ID,
27- please see here: <a href=\"https://certification.canonical.com\">certification.canonical.com</a></p><p></p>"
28-
29-[suite]
30-whitelist_filter = "^client-(cert|selftest|hwe-sru).*"
31-
32-[submission]
33-input_type = "regex"
34-input_placeholder = "Secure ID (15 or 18 characters)"
35-ok_btn_text = "Submit Results"
36-submit_to_hexr = "true"
37-
38-[exporter]
39-xml_export_path = "/tmp/submission.xml"
40-
41-[transport]
42-submit_to = "certification"
43+#!/usr/bin/env checkbox-cli
44+[launcher]
45+app_id = 2013.com.canonical.certification:certification-client
46+launcher_version = 1
47+stock_reports = submission_files, certification
48+
49+[test plan]
50+unit = 2013.com.canonical.certification::client-cert-16-04
51+filter = *client-cert*, *client-selftest*, *client-hwe*
52+
53+[ui]
54+type = converged
55diff --git a/launcher/canonical-certification-gui b/launcher/canonical-certification-gui
56deleted file mode 100755
57index 2dbbc5d..0000000
58--- a/launcher/canonical-certification-gui
59+++ /dev/null
60@@ -1,25 +0,0 @@
61-#!/usr/bin/checkbox-gui
62-
63-[welcome]
64-title = "Canonical system testing"
65-text = "<p>Welcome to Canonical System testing!</p><p></p><p>This application will
66- gather information from your system. Then you will be asked manual tests to
67- confirm that the system is working properly. Finally, you will be asked for
68- the Secure ID of the computer to submit the information to the certification
69- database.</p><p></p><p> To learn how to create or locate the Secure ID,
70- please see here: <a href=\"https://certification.canonical.com\">certification.canonical.com</a></p><p></p>"
71-
72-[suite]
73-whitelist_filter = "^.*"
74-
75-[submission]
76-input_type = "regex"
77-input_placeholder = "Secure ID (15 or 18 characters)"
78-ok_btn_text = "Submit to Certification website"
79-submit_to_hexr = "true"
80-
81-[exporter]
82-xml_export_path = "/tmp/submission.xml"
83-
84-[transport]
85-submit_to = "certification"
86diff --git a/launcher/canonical-certification-gui.desktop b/launcher/canonical-certification-gui.desktop
87deleted file mode 100644
88index ac7cf11..0000000
89--- a/launcher/canonical-certification-gui.desktop
90+++ /dev/null
91@@ -1,12 +0,0 @@
92-[Desktop Entry]
93-Name=Canonical System Testing
94-Comment=Test your system with Ubuntu
95-Type=Application
96-Exec=/usr/bin/canonical-certification-gui
97-Icon=checkbox
98-Categories=System;Qt;Application
99-Keywords=certification;certify;testing;drivers;hardware;
100-X-GNOME-Gettext-Domain=checkbox-gui
101-X-Ayatana-Appmenu-Show-Stubs=False
102-X-Ubuntu-Touch=true
103-X-Ubuntu-StageHint=SideStage
104diff --git a/launcher/canonical-hw-collection b/launcher/canonical-hw-collection
105deleted file mode 100755
106index f9464cf..0000000
107--- a/launcher/canonical-hw-collection
108+++ /dev/null
109@@ -1,33 +0,0 @@
110-#!/usr/bin/env checkbox-launcher
111-# The purpose of this launcher is to gather information about the hardware
112-# and submit it to HEXR (Hardware Enablement Cross Referencer).
113-# 1- It will just show a welcome screen and prompt for password at the
114-# beginning.
115-# 2- It will run all the jobs in the hwsubmit whitelist. They're all
116-# automated and very short, just to collect system data.
117-# 3- It will prompt whether to submit to hexr
118-# 4- Upon confirmation it will upload data to hexr and provide a URL
119-# to complete adding the system. No secure_id is needed.
120-# 5- Once the URL is provided it will exit.
121-
122-[welcome]
123-title = Gathering hardware information
124-text = Gathering hardware information. You may be prompted for your password.
125- This process will take approximately 30 seconds and you will be provided
126- with a URL through which you can confirm and register your hardware
127- submission.
128-
129-[suite]
130-whitelist_filter = ^hwsubmit$
131-whitelist_selection = ^hwsubmit$
132-skip_whitelist_selection = True
133-skip_test_selection = True
134-
135-[submission]
136-# A bogus secure_id ensures we don't ask it, as hexr doesn't need it.
137-# It can always be overridden in the .conf file.
138-secure_id = 000000000000000
139-
140-[transport]
141-submit_to = certification
142-submit_url = https://hexr.canonical.com/checkbox/submit/
143diff --git a/launcher/canonical-hw-collection-offline b/launcher/canonical-hw-collection-offline
144deleted file mode 100755
145index 7900b59..0000000
146--- a/launcher/canonical-hw-collection-offline
147+++ /dev/null
148@@ -1,22 +0,0 @@
149-#!/usr/bin/env checkbox-launcher
150-# The purpose of this launcher is to gather information about the hardware
151-# and save it to a local file for later manual collection.
152-#
153-# 1- It will just show a welcome screen and prompt for password at the
154-# beginning.
155-# 2- It will run all the jobs in the hwsubmit whitelist. They're all
156-# automated and very short, just to collect system data.
157-# 3- It will save the resulting files/reports in a location under
158-# $HOME/.local, to be indicated when the tool finishes running.
159-
160-[welcome]
161-title = Gathering hardware information
162-text = Gathering hardware information. You may be prompted for your password.
163- This process will take approximately 30 seconds and you will be provided
164- with the location of the file containing your hardware information.
165-
166-[suite]
167-whitelist_filter = ^hwsubmit$
168-whitelist_selection = ^hwsubmit$
169-skip_whitelist_selection = True
170-skip_test_selection = True

Subscribers

People subscribed via source and target branches