Checkbox

Merge lp:~sylvain-pineau/checkbox/trusted_launcher_via_bash into lp:checkbox

  1. trusted_launcher_via_bash
  2. Merge into trunk
Proposed by Sylvain Pineau
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2146
Merged at revision: 2148
Proposed branch: lp:~sylvain-pineau/checkbox/trusted_launcher_via_bash
Merge into: lp:checkbox
Diff against target: 13 lines (+1/-2)
1 file modified
plainbox/plainbox/impl/secure/checkbox_trusted_launcher.py (+1/-2)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/trusted_launcher_via_bash
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+166227@code.launchpad.net

Commit message

secure: checkbox-trusted-launcher.py: Force usage of bash to run commands.

Description of the change

MR for plainbox:

Always eval local job commands using bash

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/secure/checkbox_trusted_launcher.py'
2--- plainbox/plainbox/impl/secure/checkbox_trusted_launcher.py 2013-05-13 09:50:03 +0000
3+++ plainbox/plainbox/impl/secure/checkbox_trusted_launcher.py 2013-05-29 11:40:34 +0000
4@@ -351,8 +351,7 @@
5 if desired_job_list:
6 via_job = desired_job_list.pop()
7 via_job_result = subprocess.Popen(
8- via_job.command,
9- shell=True,
10+ ['bash', '-c', via_job.command],
11 universal_newlines=True,
12 stdout=subprocess.PIPE,
13 env=via_job.modify_execution_environment(

Subscribers

People subscribed via source and target branches