Merge lp:~sylvain-pineau/checkbox/session-in-cache-dir into lp:checkbox

[Sylvain Pineau]

MR for plainbox, use XDG_CACHE_HOME to store the session data

[lp:~sylvain-pineau/checkbox/session-in-cache-dir]

1899. By Sylvain Pineau on 2013-01-23

Use XDG_CACHE_HOME to compute session_dir

This directory is also going to be used for CHECKBOX_DATA
Note: XDG_CACHE_HOME definition borrowed from python3-xdg

[Zygmunt Krynicki (zyga)]

+1

Accepted during hangout review process

review: Approve

=== modified file 'plainbox/plainbox/impl/session.py'
--- plainbox/plainbox/impl/session.py	2012-11-29 18:59:46 +0000
+++ plainbox/plainbox/impl/session.py	2013-01-23 11:10:30 +0000
@@ -27,6 +27,7 @@
 """
 import logging
 import shutil
+import os
 import tempfile
 
 from plainbox.impl.depmgr import DependencyError
@@ -300,11 +301,17 @@
         """
         Open session state for running jobs.
 
-        This function creates a temporary directory where jobs can store their
-        temporary data. This directory will be removed by .close()
+        This function creates the cache directory where jobs can store their
+        data. See:
+        http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
         """
         if self._session_dir is None:
-            self._session_dir = tempfile.mkdtemp()
+            xdg_cache_home = os.environ.get('XDG_CACHE_HOME') or \
+                os.path.join(os.path.expanduser('~'), '.cache')
+            temp_dir = os.path.join(xdg_cache_home, 'plainbox')
+            if not os.path.isdir(temp_dir):
+                os.makedirs(temp_dir)
+            self._session_dir = tempfile.mkdtemp(dir=temp_dir)
         return self
 
     def close(self):