Merge lp:~sylvain-pineau/checkbox/server-cert-config into lp:~checkbox-dev/checkbox/checkbox-packaging

[Sylvain Pineau]

Canonical-certification-server installs two conf files, one to get the cert welcome text and the other one to install the autostart feature.

[Zygmunt Krynicki (zyga)]

While this looks good I cannot shake the feeling that this is not something one wants to configure. It feels like a intrinsic part of canonical-certification-server.

To make it true configuration I think we need to consider using ucf(1) and in general look at the policy for handling configuration files http://www.debian.org/doc/debian-policy/ap-pkg-conffiles.html

review: Needs Fixing

[Sylvain Pineau (sylvain-pineau)]

conffiles (See http://www.debian.org/doc/manuals/maint-guide/dother.en.html#conffiles):

dh_installdeb(1) automatically flags any files under the /etc directory as conffiles, so if your program only has conffiles there you do not need to specify them in this file.
[...]
When you upgrade a package, you'll be asked whether you want to keep your old configuration files or not.

So it seems that keeping our conf files in /etc is all we have to do.
ucf does the same thing as it prompts the user ifn MD5 checksums differ between the two versions.

What else should we consider?

[Zygmunt Krynicki (zyga)]

> conffiles (See http://www.debian.org/doc/manuals/maint-
> guide/dother.en.html#conffiles):
>
> dh_installdeb(1) automatically flags any files under the /etc directory as
> conffiles, so if your program only has conffiles there you do not need to
> specify them in this file.
> [...]
> When you upgrade a package, you'll be asked whether you want to keep your old
> configuration files or not.
>
> So it seems that keeping our conf files in /etc is all we have to do.
> ucf does the same thing as it prompts the user ifn MD5 checksums differ
> between the two versions.
>
> What else should we consider?

Ah, I didn't know this was the case. I recall packages with relatively complex install scripts that carefully upgraded each script using ucf.

+1

review: Approve

=== modified file 'debian/canonical-certification-server.install'
--- debian/canonical-certification-server.install	2013-10-29 10:45:12 +0000
+++ debian/canonical-certification-server.install	2013-11-07 12:29:45 +0000
@@ -1,1 +1,3 @@
 usr/bin/canonical-certification-server
+debian/extras/canonical-certification-config/canonical-certification.conf /etc/xdg
+checkbox-ng/contrib/canonical-certification-server.conf etc/init

=== added directory 'debian/extras/canonical-certification-config'
=== added file 'debian/extras/canonical-certification-config/canonical-certification.conf'
--- debian/extras/canonical-certification-config/canonical-certification.conf	1970-01-01 00:00:00 +0000
+++ debian/extras/canonical-certification-config/canonical-certification.conf	2013-11-07 12:29:45 +0000
@@ -0,0 +1,8 @@
+[common]
+welcome_text = Welcome to System Certification!
+
+ This application will gather information from your system. Then you will be asked manual tests to confirm that the system is working properly. Finally, you will be asked for the Secure ID of the computer to submit the information to the certification.canonical.com database.
+
+ To learn how to create or locate the Secure ID, please see here:
+
+ https://certification.canonical.com/home/ubuntu-certified