Checkbox

Merge lp:~sylvain-pineau/checkbox/plainbox_new_plugins_support into lp:checkbox

  1. plainbox_new_plugins_support
  2. Merge into trunk
Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 1894
Merged at revision: 1894
Proposed branch: lp:~sylvain-pineau/checkbox/plainbox_new_plugins_support
Merge into: lp:checkbox
Diff against target: 13 lines (+3/-0)
1 file modified
plainbox/plainbox/impl/runner.py (+3/-0)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/plainbox_new_plugins_support
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+143844@code.launchpad.net

Commit message

Added support for user-verify and user-interact plugins to the plainbox runner

Description of the change

This MR adds support for user-verify and user-interact plugins to the plainbox runner

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/runner.py'
2--- plainbox/plainbox/impl/runner.py 2013-01-04 13:31:02 +0000
3+++ plainbox/plainbox/impl/runner.py 2013-01-18 10:30:54 +0000
4@@ -133,6 +133,9 @@
5 result._data['outcome'] = self._outcome_callback()
6 return result
7
8+ _plugin_user_interact = _plugin_manual
9+ _plugin_user_verify = _plugin_manual
10+
11 def _just_run_command(self, job):
12 # Run the embedded command
13 return_code, io_log = self._run_command(job)

Subscribers

People subscribed via source and target branches