Merge lp:~sylvain-pineau/checkbox/fix_get_script_env into lp:checkbox

[Sylvain Pineau]

Set the "only_changes" parameter default value to False in get_script_env()

MR for plainbox

Set the "only_changes" parameter default value to False in get_script_env() so that
jobs not requiring a specific user to run have to use a verbatim copy of the environment.

[Zygmunt Krynicki (zyga)]

Thanks for finding, debugging and fixing this

This teaches us that despite coverage in that area we need better testing thought process and time to implement such tests. We also _really_ need to push to get integration tests to a good coverage degree. It's the biggest bang for the buck as they say

review: Approve

[Zygmunt Krynicki (zyga)]

The attempt to merge lp:~sylvain-pineau/checkbox/fix_get_script_env into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] Starting tests...
[precise] CheckBox test suite: pass
[precise] PlainBox test suite: fail
[precise] stdout: http://paste.ubuntu.com/5585585/
[precise] stderr: http://paste.ubuntu.com/5585586/
[precise] Integration tests: fail
[precise] stdout:
[precise] stderr: http://paste.ubuntu.com/5585587/
[precise] Suspending VM
[quantal] Bringing VM 'up'
[quantal] Starting tests...
[quantal] CheckBox test suite: pass
[quantal] PlainBox test suite: pass
[quantal] Integration tests: pass
[quantal] Suspending VM

You are trying to send an empty document, exiting.

[Zygmunt Krynicki (zyga)]

The attempt to merge lp:~sylvain-pineau/checkbox/fix_get_script_env into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] Starting tests...
[precise] CheckBox test suite: pass
[precise] PlainBox test suite: fail
[precise] stdout: http://paste.ubuntu.com/5586387/
[precise] stderr: http://paste.ubuntu.com/5586388/
[precise] Integration tests: fail
[precise] stdout:
[precise] stderr: http://paste.ubuntu.com/5586389/
[precise] Suspending VM
[quantal] Bringing VM 'up'
[quantal] Starting tests...
[quantal] CheckBox test suite: pass
[quantal] PlainBox test suite: pass
[quantal] Integration tests: pass
[quantal] Suspending VM

You are trying to send an empty document, exiting.

[Zygmunt Krynicki (zyga)]

The attempt to merge lp:~sylvain-pineau/checkbox/fix_get_script_env into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] Starting tests...
[precise] CheckBox test suite: pass
[precise] PlainBox test suite: fail
[precise] stdout: http://paste.ubuntu.com/5586407/
[precise] stderr: http://paste.ubuntu.com/5586408/
[precise] Integration tests: fail
[precise] stdout:
[precise] stderr: http://paste.ubuntu.com/5586409/
[precise] Suspending VM
[quantal] Bringing VM 'up'
[quantal] Starting tests...
[quantal] CheckBox test suite: pass
[quantal] PlainBox test suite: pass
[quantal] Integration tests: pass
[quantal] Suspending VM

You are trying to send an empty document, exiting.

[Zygmunt Krynicki (zyga)]

The attempt to merge lp:~sylvain-pineau/checkbox/fix_get_script_env into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] Starting tests...
[precise] CheckBox test suite: pass
[precise] PlainBox test suite: fail
[precise] stdout: http://paste.ubuntu.com/5586487/
[precise] stderr: http://paste.ubuntu.com/5586488/
[precise] Integration tests: fail
[precise] stdout:
[precise] stderr: http://paste.ubuntu.com/5586489/
[precise] Suspending VM
[quantal] Bringing VM 'up'
[quantal] Starting tests...
[quantal] CheckBox test suite: pass
[quantal] PlainBox test suite: pass
[quantal] Integration tests: pass
[quantal] Suspending VM

You are trying to send an empty document, exiting.

[Zygmunt Krynicki (zyga)]

Sorry for the horrible ping-pong, I have no better ways of examining the state than this. It's really strange and elusive as it only fails once, then everything works until the next time, where it fails once, again.

=== modified file 'plainbox/plainbox/impl/runner.py'
--- plainbox/plainbox/impl/runner.py	2013-02-26 17:03:32 +0000
+++ plainbox/plainbox/impl/runner.py	2013-03-04 16:46:21 +0000
@@ -251,7 +251,7 @@
             'io_log': io_log
         })
 
-    def _get_script_env(self, job, only_changes=True):
+    def _get_script_env(self, job, only_changes=False):
         """
         Compute the environment the script will be executed in
         """