lp:~sylvain-pineau/checkbox/fix-1522768
- Get this branch:
- bzr branch lp:~sylvain-pineau/checkbox/fix-1522768
Branch merges
- Sylvain Pineau (community): Approve
- Pierre Equoy: Approve
-
Diff: 5922 lines (+5568/-21)11 files modifiedcheckbox-support/checkbox_support/parsers/submission.py (+18/-3)
checkbox-support/checkbox_support/parsers/tests/fixtures/submission_info_udevadm.xml (+9/-0)
checkbox-support/checkbox_support/parsers/tests/fixtures/submission_udev.xml (+11/-0)
checkbox-support/checkbox_support/parsers/tests/fixtures/submission_udev_armhf.xml (+7/-0)
checkbox-support/checkbox_support/parsers/tests/fixtures/submission_udev_without_lsblk.xml (+5364/-0)
checkbox-support/checkbox_support/parsers/tests/test_submission.py (+8/-2)
checkbox-support/checkbox_support/parsers/tests/test_udevadm.py (+61/-5)
checkbox-support/checkbox_support/parsers/udevadm.py (+69/-9)
providers/plainbox-provider-checkbox/jobs/info.txt.in (+13/-1)
providers/plainbox-provider-checkbox/jobs/miscellanea.txt.in (+1/-0)
providers/plainbox-provider-resource-generic/bin/udev_resource (+7/-1)
Related bugs
Bug #1522768: disk/detect fails and disk-related tests are skipped on eMMC unit | Critical | Fix Released |
Related blueprints
Branch information
Recent revisions
- 4203. By Sylvain Pineau
-
checbox-
support: parsers: submission: Fake an empty lsblk_attachment if not present If we reprocess old submissions without the new attachment, the (submission)
parser should not fail and just pass en empty string to the udevadm parser. - 4202. By Sylvain Pineau
-
checkbox-
support: parsers: submission: Send lsblk data to UdevadmParser From now on, all submission must contain lsblk data.
The submission parser extracts them from the attachment and pass the raw data
to the udevadm parser.That way devices categorization will be the same from a live plainbox run and
from a submission parsing on certification servers. - 4201. By Sylvain Pineau
-
providers:checkbox: Add a new mandatory lsblk_attachment
The submission parser needs to send lsblk data to the udevadm parser.
- 4200. By Sylvain Pineau
-
checkbox-
support: parsers: udevadm: Properly mark Realtek card reader as such We've found that the udev env property DRIVER can actually contains the
product name of the device. - 4199. By Sylvain Pineau
-
providers:
resource- generic: udev_resource: Pass the result of lsblk to UdevadmParser Similarly to the --command, this tool gets a new argument, --lsblkcommand.
The udevadm parser is now able to check partition mount points and to mark
eMMC drives as DISK. - 4198. By Sylvain Pineau
-
checkbox-
support: parsers: udevadm: Categorize eMMC internal drives as DISK eMMC drives and MMC removable storage are exactly the same thing and it's
impossible to distinguish them.
But some recent systems have eMMC internal drives as their main and unique
storage device. In that case we need a way to mark them as DISK.To do so, the idea is to check two things:
1. The / mount point will tell if we have to consider the device,
2. If the MMC type is actually "MMC" as we don't want to run heavy tests on SD
cards (e.g on a pandaboard).In order to get the mount points of all partitions, we're calling an external
command, `lsblk` (as libudev does not call libmount to provide such info).The exact command is:
lsblk -i -n -P -o KNAME,TYPE,
MOUNTPOINT It works even on Ubuntu 12.04 (util-linux 2.20.1) and snappy.
The result of lsblk is a new parameter of UdevadmParser.
- 4197. By Pierre Equoy
-
"automatic merge of lp:~pierre-equoy/checkbox/fix-1536888-pm_test-crash-when-fwts-call-fails/ by tarmac [r=sylvain-pineau][bug=1536888][author=
pierre- equoy]" - 4196. By Sylvain Pineau
-
"automatic merge of lp:~sylvain-pineau/checkbox/new_udevadm_test_data/ by tarmac [r=sylvain-
pineau] [bug=][ author= sylvain- pineau] "
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:checkbox