Checkbox

Merge lp:~sylvain-pineau/checkbox/fix-1474199 into lp:checkbox

  1. fix-1474199
  2. Merge into trunk
Proposed by Sylvain Pineau
Status: Rejected
Rejected by: Sylvain Pineau
Proposed branch: lp:~sylvain-pineau/checkbox/fix-1474199
Merge into: lp:checkbox
Diff against target: 11 lines (+1/-0)
1 file modified
providers/plainbox-provider-checkbox/bin/camera_test (+1/-0)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/fix-1474199
Reviewer Review Type Date Requested Status
kaxing (community) Needs Fixing
Checkbox Developers Pending
Review via email: mp+285870@code.launchpad.net

Description of the change

Fixes the linked bug

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Please retest on the guilty platform before merging

Revision history for this message
kaxing (kaxing) wrote :

manually applied the change to another skylake system but still able to reproduce the same issue.
(note: I can't recall which one is the system that I was tested before.)

review: Needs Fixing

Unmerged revisions

4218. By Sylvain Pineau

providers:checkbox:bin:camera_test: Always deinterlace the displayed video stream

Fixes: https://bugs.launchpad.net/plainbox-provider-checkbox/+bug/1474199

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/bin/camera_test'
2--- providers/plainbox-provider-checkbox/bin/camera_test 2015-10-27 07:34:41 +0000
3+++ providers/plainbox-provider-checkbox/bin/camera_test 2016-02-12 13:37:01 +0000
4@@ -238,6 +238,7 @@
5 pipespec = ("v4l2src device=%(device)s "
6 "! %(type)s,width=%(width)d,height=%(height)d "
7 "! %(plugin)s "
8+ "! deinterlace "
9 "! autovideosink"
10 % {'device': self.args.device,
11 'type': self._gst_video_type,

Subscribers

People subscribed via source and target branches