Merge lp:~sylvain-pineau/checkbox/fix-1458577 into lp:checkbox

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 4203
Merged at revision: 4210
Proposed branch: lp:~sylvain-pineau/checkbox/fix-1458577
Merge into: lp:checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
plainbox/plainbox/impl/commands/inv_run.py (+1/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/fix-1458577
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+285172@code.launchpad.net

Description of the change

Fixes the linked bug

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

11:57 <@zyga> spineau: that bug is more complex
11:57 <@zyga> spineau: +1 on the merge but there's a different problem there too
11:57 <@zyga> spineau: you can Ctrl-C at so many places after entering input and before we have a result
11:57 <@zyga> spineau: that we still lose stuff
11:57 <@zyga> spineau: the only way to solve that would to instantly keep a partial "under construction" result in the session somewhere
11:58 <@spineau> zyga: I see

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Let's land this simple fix first.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/commands/inv_run.py'
2--- plainbox/plainbox/impl/commands/inv_run.py 2015-11-04 14:35:46 +0000
3+++ plainbox/plainbox/impl/commands/inv_run.py 2016-02-05 10:49:02 +0000
4@@ -807,7 +807,7 @@
5 if cmd == 'run' or cmd is None:
6 result_builder = self.runner.run_job(
7 job, job_state, self.config, ui
8- ).get_builder()
9+ ).get_builder(comments=comments)
10 elif cmd == 'comment':
11 new_comment = input(self.C.BLUE(
12 _('Please enter your comments:') + '\n'))

Subscribers

People subscribed via source and target branches