Merge lp:~sylvain-pineau/checkbox/fix-1420531 into lp:checkbox

[Sylvain Pineau]

Fixes the linked bug, a new touchpad test to ensure that we can get a smooth and continuous move for 10s, cert-blocker.

[Zygmunt Krynicki (zyga)]

11:46 <@zyga> spineau: hmm
11:46 <@zyga> spineau: I tested it but it fails for me
11:46 <@zyga> spineau: I ran it on a desktop, with a mouse
11:46 <@zyga> ah
11:46 <@zyga> you have to keeeep moving it
11:46 <@zyga> hmm
11:46 <@zyga> I'd make the threshold bigger and add a big big lable to say what's going on

[Ara Pulido (ara)]

I agree that the instructions need to be clear, so people know what to do well in advance, but I do not agree to move the threshold to about a second, it should be a lot less than that. If not, we may miss the bug.

[Zygmunt Krynicki (zyga)]

I somewhat agree with Ara but I wanted to make it easy to write this test. If I were super picky and trying to come up with best test experience I would ask the user to spin their finger on the touchpad a few times then only pass the test if the user can do that for 10 seconds. If not I'd not fail the test, just restart the counter. Failing the test should be an explicit action the user can do (a button perhaps).

This could be coupled with a spinning wheel UI where we show the user how to move the finger and perhaps change the color from gray (neutral) to green (success) or red (failure). All of this is nice but would require more work and personally I don't know how to implement this right now. Perhaps Maciek, with more experience in QML, can help.

[lp:~sylvain-pineau/checkbox/fix-1420531]

3906. By Sylvain Pineau on 2015-07-22

providers:checkbox: New touchpad test to check continuous move for 10s

Fixes: https://bugs.launchpad.net/plainbox-provider-checkbox/+bug/1420531

3907. By Sylvain Pineau on 2015-07-22

providers:certification: Add the new touchpad move test to 14.04 testplans

touchpad/continuous-move, a certification blocker.

[Sylvain Pineau (sylvain-pineau)]

self-approved

review: Approve

=== modified file 'providers/plainbox-provider-certification-client/units/client-cert-14-04-3.pxu'
--- providers/plainbox-provider-certification-client/units/client-cert-14-04-3.pxu	2015-05-20 10:13:54 +0000
+++ providers/plainbox-provider-certification-client/units/client-cert-14-04-3.pxu	2015-07-22 07:15:59 +0000
@@ -229,6 +229,7 @@
     power-management/fwts_wakealarm-log-attach
     __touchpad__
     touchpad/detected-as-mouse                             certification-status=blocker
+    touchpad/continuous-move                               certification-status=blocker
     touchpad/horizontal                                    certification-status=blocker
     touchpad/vertical                                      certification-status=blocker
     touchpad/singletouch-automated                         certification-status=blocker

=== modified file 'providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu'
--- providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu	2015-05-20 23:01:31 +0000
+++ providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu	2015-07-22 07:15:59 +0000
@@ -218,6 +218,7 @@
     power-management/fwts_wakealarm-log-attach
     __touchpad__
     touchpad/detected-as-mouse                             certification-status=blocker
+    touchpad/continuous-move                               certification-status=blocker
     touchpad/horizontal                                    certification-status=blocker
     touchpad/vertical                                      certification-status=blocker
     touchpad/singletouch-automated                         certification-status=blocker

=== added file 'providers/plainbox-provider-checkbox/data/touch_continuous_move_test.qml'
--- providers/plainbox-provider-checkbox/data/touch_continuous_move_test.qml	1970-01-01 00:00:00 +0000
+++ providers/plainbox-provider-checkbox/data/touch_continuous_move_test.qml	2015-07-22 07:15:59 +0000
@@ -0,0 +1,93 @@
+/* This file is part of Checkbox.
+
+ Copyright 2015 Canonical Ltd.
+ Written by:
+ Sylvain Pineau <[e-mail]>
+
+ Checkbox is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License version 3,
+ as published by the Free Software Foundation.
+
+ Checkbox is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with Checkbox.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+
+Rectangle {
+    width: 500
+    height: 500
+
+    MouseArea {
+        anchors.fill: parent
+        anchors.margins: 30
+        onPositionChanged: {
+            if (timer2.running) {
+                timer2.restart();
+            }
+        }
+        hoverEnabled: true
+    }
+
+    Column {
+        spacing: units.gu(5)
+        anchors.centerIn: parent
+        Text {
+            id: legend
+            anchors.horizontalCenter: parent.horizontalCenter
+            text: "Continuously move your mouse cursor"
+            font.bold: true
+            font.pointSize: 30
+        }
+        Text {
+            id: countdown
+            anchors.horizontalCenter: parent.horizontalCenter
+            text: " "
+            font.pointSize: 40
+        }
+    }
+
+    Timer {
+        id: timer1
+        interval: 1000
+        running: true
+        repeat: true
+        property int timeout: 11
+        onTriggered: {
+            timeout = timeout - 1
+            countdown.text = timeout
+            if (timeout <= 0) {
+                running = false
+                console.log("PASS")
+                Qt.quit()
+            }
+        }
+    }
+
+    Timer {
+        id: timer2
+        interval: 200
+        running: false
+        repeat: true
+        onTriggered: {
+            running = false
+            console.log("FAIL")
+            Qt.quit()
+        }
+    }
+
+    Timer {
+        id: timer3
+        interval: 2000
+        running: true
+        onTriggered: {
+            timer2.running = true
+        }
+    }
+}

=== modified file 'providers/plainbox-provider-checkbox/jobs/touchpad.txt.in'
--- providers/plainbox-provider-checkbox/jobs/touchpad.txt.in	2015-03-05 13:18:05 +0000
+++ providers/plainbox-provider-checkbox/jobs/touchpad.txt.in	2015-07-22 07:15:59 +0000
@@ -205,3 +205,16 @@
 _description:
  This test will check if your touchpad was detected as a mouse.
 
+plugin: user-interact
+id: touchpad/continuous-move
+requires: dmi.product in ['Notebook','Laptop','Portable']
+estimated_duration: 12
+command: qmlscene -qt5 --fullscreen $PLAINBOX_PROVIDER_DATA/touch_continuous_move_test.qml 2>&1 | grep -o PASS
+_description:
+ PURPOSE:
+     Touchpad continuous move verification
+ STEPS:
+     1. Select "Test" when ready and continuously move your cursor within the borders of the displayed test window.
+     You'll need to keep moving your finger on the touchpad for 10 seconds.
+ VERIFICATION:
+     Did the mouse cursor move without interruption?