Checkbox

Merge lp:~sylvain-pineau/checkbox/fix-1402612 into lp:checkbox

  1. fix-1402612
  2. Merge into trunk
Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 4203
Merged at revision: 4207
Proposed branch: lp:~sylvain-pineau/checkbox/fix-1402612
Merge into: lp:checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
plainbox/plainbox/impl/exporter/xlsx.py (+1/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/fix-1402612
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Sylvain Pineau Needs Resubmitting
Review via email: mp+285187@code.launchpad.net

Description of the change

Fixes the linked bug

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) :
lp:~sylvain-pineau/checkbox/fix-1402612 updated
4203. By Sylvain Pineau

plainbox:exporter:xlsx: Skip malformed packagenon-perfect package resource data

Fixes: https://bugs.launchpad.net/plainbox/+bug/1402612

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

oh, clever. thanks

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Thanks :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/exporter/xlsx.py'
2--- plainbox/plainbox/impl/exporter/xlsx.py 2015-09-25 09:54:22 +0000
3+++ plainbox/plainbox/impl/exporter/xlsx.py 2016-02-05 13:36:13 +0000
4@@ -365,7 +365,7 @@
5 for i, pkg in enumerate(data["resource_map"][resource]):
6 self.worksheet1.write_row(
7 22 + i, 1,
8- [pkg['name'], pkg['version']],
9+ [pkg.get("name", ""), pkg.get("version", "")],
10 self.format08 if i % 2 else self.format09
11 )
12 self.worksheet1.set_row(

Subscribers

People subscribed via source and target branches