lp:~sylvain-pineau/checkbox/fix-1361071

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3527

Sylvain Pineau (community): Approve on 2015-01-09

Zygmunt Krynicki (community): Approve on 2015-01-09

Diff: 263 lines (+53/-27)

7 files modified

checkbox-support/checkbox_support/parsers/udevadm.py (+15/-4)
plainbox/plainbox/impl/ctrl.py (+1/-1)
plainbox/plainbox/impl/secure/launcher1.py (+25/-8)
plainbox/plainbox/impl/secure/test_launcher1.py (+3/-3)
plainbox/plainbox/impl/test_ctrl.py (+2/-2)
providers/plainbox-provider-checkbox/jobs/disk.txt.in (+6/-8)
providers/plainbox-provider-resource-generic/bin/udev_resource (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1361071: "Problem with field requires: wrong" error occurred during the job generation stage

Medium

Fix Released

Link a bug report

Related blueprints

3531. By Sylvain Pineau on 2015-01-09

providers:checkbox:disks.txt.in: staging/disk now use the device resource

This new template job now use the udevadm parser to solve two problems:
- all the device parsing logic is delegated to the resource, not the template
  filter (i.e. removal of ram and loop devices)
- the udev resource is not the default udevadm parser and thus not part of
  default whitelists, causing https://bugs.launchpad.net/plainbox/+bug/1361071

Fixes https://bugs.launchpad.net/plainbox/+bug/1361071

3530. By Sylvain Pineau on 2015-01-09

plainbox:impl:secure:launcher1.py: Add support for template jobs

When the generator job is a resource job, the trusted launcher will now recreate
all the possible template jobs that use it.
That way generated jobs requiring root privileges can be created from templates
and still use the plainbox trusted launcher.
The command line options are untouched.

3529. By Sylvain Pineau on 2015-01-09

plainbox:ctrl: Change how we get the source job to create parent_env

For template jobs, job.origin.source.job fails withthe following error:

AttributeError: 'FileTextSource' object has no attribute 'job'

job.origin.source.job cannot be used for all types of generated jobs.
A generic way to get the source job is to use now job_state.via_job.

3528. By Sylvain Pineau on 2015-01-09

providers:resource-generic:udev_resource: return the device name attribute

The device name attribute is now part of the output and can be used by local or
template jobs.

3527. By Sylvain Pineau on 2015-01-09

checkbox-support:parsers:udevadm.py: Keep the device name in the slots

Most of local/template jobs are using the device name /dev/<XXXX> to create
child jobs.
To avoid recreating the full device path in the job definition, the udev parser
now returns - if present - the device name, the one stating with "N: <XXXX>" in
the "udevadm info --export-db" output.

3526. By Sylvain Pineau on 2015-01-08

"automatic merge of lp:~sylvain-pineau/checkbox/fix-1406719/ by tarmac [r=sylvain-pineau][bug=1406719][author=sylvain-pineau]"

3525. By Zygmunt Krynicki on 2015-01-08

"automatic merge of lp:~zkrynicki/checkbox/outcome-apis-v2/ by tarmac [r=roadmr][bug=][author=zkrynicki]"

3524. By Zygmunt Krynicki on 2015-01-08

"automatic merge of lp:~zkrynicki/checkbox/via-changes/ by tarmac [r=kissiel][bug=][author=zkrynicki]"

3523. By Zygmunt Krynicki on 2015-01-08

"automatic merge of lp:~zkrynicki/checkbox/outcome-apis/ by tarmac [r=sylvain-pineau][bug=][author=zkrynicki]"

3522. By Zygmunt Krynicki on 2015-01-05

"automatic merge of lp:~zkrynicki/checkbox/remove-experimental-job-tree-node/ by tarmac [r=kissiel][bug=][author=zkrynicki]"