Merge lp:~sylvain-pineau/checkbox/fix-1258477 into lp:checkbox

Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2547
Merged at revision: 2547
Proposed branch: lp:~sylvain-pineau/checkbox/fix-1258477
Merge into: lp:checkbox
Diff against target: 17 lines (+2/-1)
1 file modified
plainbox/plainbox/impl/commands/test_run.py (+2/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/fix-1258477
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+198281@code.launchpad.net

Description of the change

Please read the commit message and the linked bug for context.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Excellent find Sylvain. How did you figure out which moudle was causing this?

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Using a dichotomic search, after working a unittests using setup.py -s, I realized that just a small subset of the whole testsuite was causing this error.
And you were right It was all about finalization, not logging but threads.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/commands/test_run.py'
2--- plainbox/plainbox/impl/commands/test_run.py 2013-12-09 12:36:09 +0000
3+++ plainbox/plainbox/impl/commands/test_run.py 2013-12-09 15:48:35 +0000
4@@ -39,11 +39,12 @@
5 from plainbox.impl.exporter.text import TextSessionStateExporter
6 from plainbox.impl.exporter.xml import XMLSessionStateExporter
7 from plainbox.testing_utils.io import TestIO
8-from plainbox.vendor.mock import patch
9+from plainbox.vendor.mock import patch, Mock
10
11
12 class TestRun(TestCase):
13
14+ @patch.dict('sys.modules', {'concurrent': Mock()})
15 def setUp(self):
16 # session data are kept in XDG_CACHE_HOME/plainbox/.session
17 # To avoid resuming a real session, we have to select a temporary

Subscribers

People subscribed via source and target branches