Merge lp:~sylvain-pineau/checkbox/bug990133 into lp:checkbox

Proposed by Sylvain Pineau
Status: Merged
Merged at revision: 1642
Proposed branch: lp:~sylvain-pineau/checkbox/bug990133
Merge into: lp:checkbox
Diff against target: 43 lines (+9/-2)
3 files modified
debian/changelog (+4/-0)
jobs/camera.txt.in (+1/-1)
scripts/camera_test (+4/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/bug990133
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+122867@code.launchpad.net

Description of the change

Added a 10s timeout to the camera still test (same behaviour as camera/display)

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK, thanks! merging...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-09-05 08:54:38 +0000
3+++ debian/changelog 2012-09-05 13:12:21 +0000
4@@ -55,6 +55,10 @@
5 since they were missed in the previous merge
6 * Attach the output of udev_resource, for debugging purposes (LP: #974271)
7
8+ [Sylvain Pineau]
9+ * scripts/camera_test, jobs/camera.txt.in: Added a 10s timeout to the camera
10+ still test (LP: #990133)
11+
12 [Zygmunt Krynicki]
13 * Fixed simple duplicate 'the' mistakes (LP: #1040022)
14
15
16=== modified file 'jobs/camera.txt.in'
17--- jobs/camera.txt.in 2012-08-14 19:07:46 +0000
18+++ jobs/camera.txt.in 2012-09-05 13:12:21 +0000
19@@ -33,7 +33,7 @@
20 PURPOSE:
21 This test will check that the built-in camera works
22 STEPS:
23- 1. Click on Test to display a still image from the camera
24+ 1. Click on Test to display a still image from the camera for ten seconds.
25 VERIFICATION:
26 Did you see the image?
27
28
29=== modified file 'scripts/camera_test'
30--- scripts/camera_test 2012-08-14 19:07:46 +0000
31+++ scripts/camera_test 2012-09-05 13:12:21 +0000
32@@ -271,7 +271,10 @@
33 self._pipeline.set_state(Gst.State.NULL)
34
35 if not quiet:
36- call(["eog", filename])
37+ try:
38+ call(["timeout", "-k", "11", "10", "eog", filename])
39+ except CalledProcessError:
40+ pass
41
42 def _supported_resolutions_to_string(self, supported_resolutions):
43 """

Subscribers

People subscribed via source and target branches