Merge ~sylvain-pineau/checkbox-support:fwts_test_no_syslog_v3 into checkbox-support:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 249ae980464224ff573ee1c3ff8cd47d8e1ab4c5
Merged at revision: ac5e4fcbdbace38aa5bcff1eed8a78e63a50ea37
Proposed branch: ~sylvain-pineau/checkbox-support:fwts_test_no_syslog_v3
Merge into: checkbox-support:master
Diff against target: 25 lines (+5/-5)
1 file modified
checkbox_support/scripts/fwts_test.py (+5/-5)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+354871@code.launchpad.net

Description of the change

Fix a stupid bug where 6 consecutive "if" should be "if + 5 elif"

Ref: http://kernel.ubuntu.com/git/hwe/fwts.git/tree/src/lib/src/fwts_framework.c#n527

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

LGTM, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_support/scripts/fwts_test.py b/checkbox_support/scripts/fwts_test.py
2index f5cc00b..97a717a 100644
3--- a/checkbox_support/scripts/fwts_test.py
4+++ b/checkbox_support/scripts/fwts_test.py
5@@ -320,15 +320,15 @@ def main():
6 for test in results.keys():
7 if 'FAILED_CRITICAL' in results[test]:
8 critical_fails.append(test)
9- if 'FAILED_HIGH' in results[test]:
10+ elif 'FAILED_HIGH' in results[test]:
11 high_fails.append(test)
12- if 'FAILED_MEDIUM' in results[test]:
13+ elif 'FAILED_MEDIUM' in results[test]:
14 medium_fails.append(test)
15- if 'FAILED_LOW' in results[test]:
16+ elif 'FAILED_LOW' in results[test]:
17 low_fails.append(test)
18- if 'PASSED' in results[test]:
19+ elif 'PASSED' in results[test]:
20 passed.append(test)
21- if 'ABORTED' in results[test]:
22+ elif 'ABORTED' in results[test]:
23 aborted.append(test)
24 else:
25 return 1

Subscribers

People subscribed via source and target branches