Merge ~sylvain-pineau/checkbox-support:usb_partion_hub_version into checkbox-support:master

[Sylvain Pineau]

This MR tweaks the bus property of PARTITION "devices". The original usb is kept for usb2 versions (needless to change the corresponding jobs using the removable_partition resource). But for usb3, the bus is then changed to usb3.

To test it, just run from the resource provider bin dir:

plainbox-provider-resource/bin$ ./udev_resource -f PARTITION
path: /devices/pci0000:00/0000:00:14.0/usb4/4-1/4-1:1.0/host15/target15:0:0/15:0:0:0/block/sdb/sdb1
name: sdb1
bus: usb3
category: PARTITION
product: sdb1
product_slug: sdb1

Note that a usb2 device plugged into a usb3 port will report bus: usb.

[Maciej Kisielewski (kissiel)]

Cool use of a for/else idiom!
Also LGTM, +1

review: Approve

[Sylvain Pineau (sylvain-pineau)]

First time I see an obvious case to use it, I'm quite proud :)

diff --git a/checkbox_support/parsers/udevadm.py b/checkbox_support/parsers/udevadm.py
index 7f5acc7..55efe46 100644
--- a/checkbox_support/parsers/udevadm.py
+++ b/checkbox_support/parsers/udevadm.py
@@ -186,7 +186,12 @@ class UdevadmDevice(object):
             self._environment.get("DEVTYPE") == "partition" and self._stack
         ):
             if any(d.bus == 'usb' for d in self._stack):
-                return 'usb'
+                for d in self._stack:
+                    # Report the current usb hub version
+                    if d._environment.get("ID_MODEL_ID") == '0003':
+                        return 'usb3'
+                else:
+                    return 'usb'
             else:
                 return self._stack[-2]._environment.get("SUBSYSTEM")